Skip to content

Fix unintended behavior change in elementtree introduced in #114269 #114737

Closed
Closed
Fix unintended behavior change in elementtree introduced in #114269#114737
Assignees
colesbury
Labels
3.11only security fixes3.12only security fixes3.13only security fixestopic-XMLtype-bugAn unexpected behavior, bug, or error

Description

@Prometheus3375
Prometheus3375
opened on Jan 29, 2024

Bug report

Bug description:

As it was discussed here, after merging of #114269 it.root is no longer None once an iterator is created. There was no intention to change this, it should be reverted.

Meanwhile, I think it will be good to add test for root attribute.

  • Right after function returned iterator: it.root must be None.
  • After iterator exhaustion: it.root must be an instance of xml.etree.ElementTree.Element.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Other

Linked PRs

Activity

  1. Prometheus3375
    added
    type-bugAn unexpected behavior, bug, or error
    on Jan 29, 2024
  2. Eclips4
    added
    3.13only security fixes
    on Jan 30, 2024
  3. Eclips4
    assigned
    colesbury
    on Jan 30, 2024
  4. ronaldoussoren
    added
    topic-XML
    on Jan 30, 2024
  5. ronaldoussoren
    changed the title [-]Fix unintended behavior change introduced in #114269[/-] [+]Fix unintended behavior change in elementtree introduced in #114269[/+] on Jan 30, 2024
  6. colesbury
    added a commit that references this issue on Jan 30, 2024

    pythongh-114737: Revert change to ElementTree.iterparse "root" attribute

    212ef9f
  7. serhiy-storchaka
    added
    3.11only security fixes
    3.12only security fixes
    on Jan 31, 2024
  8. serhiy-storchaka
    added a commit that references this issue on Jan 31, 2024

    gh-114737: Revert change to ElementTree.iterparse "root" attribute (G…

    66f95ea
  9. miss-islington
    added 2 commits that reference this issue on Jan 31, 2024

    pythongh-114737: Revert change to ElementTree.iterparse "root" attrib…

    8ebd614

    pythongh-114737: Revert change to ElementTree.iterparse "root" attrib…

    e842682
  10. serhiy-storchaka
    closed this as completedon Jan 31, 2024

  11. serhiy-storchaka commented on Jan 31, 2024

    @serhiy-storchaka
    serhiy-storchaka
    on Jan 31, 2024
    Member

    Thank you for your report @Prometheus3375.

  12. serhiy-storchaka
    added 2 commits that reference this issue on Jan 31, 2024

    [3.12] gh-114737: Revert change to ElementTree.iterparse "root" attri…

    5d7b90d

    [3.11] gh-114737: Revert change to ElementTree.iterparse "root" attri…

    3982049
  13. aisk
    added a commit that references this issue on Feb 11, 2024

    pythongh-114737: Revert change to ElementTree.iterparse "root" attrib…

    d23850c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

3.11only security fixes3.12only security fixes3.13only security fixestopic-XMLtype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions