Skip to content

Update autoconf to warn when building under wasm32-unknown-emscripten #113632

Closed
Closed
Update autoconf to warn when building under wasm32-unknown-emscripten#113632
Assignees
brettcannon
Labels
3.13only security fixesOS-wasibuildThe build process and cross-builddeferred-blockertype-bugAn unexpected behavior, bug, or error

Description

@brettcannon
brettcannon
opened on Jan 1, 2024

Bug report

Bug description:

Support for wasm32-unknown-emscripten was dropped in python/peps#3612 . As part of PEP 11, a configure error needs to be triggered when building for the platform.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

Activity

  1. brettcannon
    added
    type-bugAn unexpected behavior, bug, or error
    buildThe build process and cross-build
    OS-wasi
    3.13only security fixes
    deferred-blocker
    on Jan 1, 2024
  2. ezio-melotti
    added this to Release and Deferred blockers 🚫on Jan 1, 2024
  3. github-project-automation
    moved this to Todo in Release and Deferred blockers 🚫on Jan 1, 2024

  4. brettcannon commented on Jan 15, 2024

    @brettcannon
    brettcannon
    on Jan 15, 2024
    MemberAuthor

    This is blocked on the SC answering python/steering-council#226 .

  5. brettcannon commented on Jan 31, 2024

    @brettcannon
    brettcannon
    on Jan 31, 2024
    MemberAuthor

    Another option is to have a warning anytime you build on a platform that isn't supported.

  6. erlend-aasland commented on Feb 1, 2024

    @erlend-aasland
    erlend-aasland
    on Feb 1, 2024
    Contributor

    Another option is to have a warning anytime you build on a platform that isn't supported.

    We already have the following code in place:

    https://github.com/python/cpython/blob/5ce193e65a7e6f239337a8c5305895cf8a4d2726/configure.ac#L961C13-L995

    Removing this line...:

    cpython/configure.ac

    Line 982 in 5ce193e

    [wasm32-unknown-emscripten/clang], [PY_SUPPORT_TIER=3], dnl WebAssembly Emscripten

    ... should end up producing a warning.

  7. brettcannon
    changed the title [-]Add error to autoconf when building under `wasm32-unknown-emscripten`[/-] [+]Update autoconf to warn when building under `wasm32-unknown-emscripten`[/+] on Feb 1, 2024
  8. brettcannon
    self-assigned this
    on Feb 1, 2024
  9. brettcannon
    added a commit that references this issue on Feb 9, 2024

    pythonGH-113632: update configure.ac for WebAssembly support tiers

    366dbb8
  10. erlend-aasland
    added a commit that references this issue on Feb 9, 2024

    GH-113632: update configure.ac for WebAssembly support tiers (#115192)

    c968dc7
  11. erlend-aasland
    closed this as completedon Feb 9, 2024
  12. github-project-automation
    moved this from Todo to Done in Release and Deferred blockers 🚫on Feb 9, 2024
  13. fsc-eriker
    added a commit that references this issue on Feb 14, 2024

    pythonGH-113632: update configure.ac for WebAssembly support tiers (p…

    178acc2
  14. erlend-aasland
    added a commit that references this issue on Apr 13, 2024

    pythongh-96398: Purge Emscripten code from configure.ac

    ad44734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

3.13only security fixesOS-wasibuildThe build process and cross-builddeferred-blockertype-bugAn unexpected behavior, bug, or error

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions