Skip to content

TextIOWrapper.reconfigure() crashes if encoding is not string or None #111942

Closed
Closed
TextIOWrapper.reconfigure() crashes if encoding is not string or None#111942
Assignees
serhiy-storchaka
Labels
topic-IOtype-crashA hard crash of the interpreter, possibly with a core dump

Description

@serhiy-storchaka
serhiy-storchaka
opened on Nov 10, 2023

Crash report

What happened?

Unlike to TextIOWrapper constructor, TextIOWrapper.reconfigure() does not check that the encoding argument is actually None or string. If it is not None, it calls _PyUnicode_EqualToASCIIString that only works with strings and crashes in debug build. There may be other similar errors in other arguments.

>>> import sys
>>> sys.stdout.reconfigure(encoding=42)
Objects/unicodeobject.c:552: _PyUnicode_CheckConsistency: Assertion failed: PyType_HasFeature((Py_TYPE(((PyObject*)((op))))), ((1UL << 28)))
Enable tracemalloc to get the memory block allocation traceback

object address  : 0x55a2e3147ca8
object refcount : 4294967295
object type     : 0x55a2e3119f00
object type name: int
object repr     : 42

Fatal Python error: _PyObject_AssertFailed: _PyObject_AssertFailed
Python runtime state: initialized

Current thread 0x00007fc99ee43740 (most recent call first):
  File "<stdin>-1", line 1 in <module>
Aborted (core dumped)

CPython versions tested on:

3.10, 3.11, 3.12

Operating systems tested on:

No response

Output from running 'python -VV' on the command line:

No response

Linked PRs

Activity

  1. serhiy-storchaka
    added
    topic-IO
    type-crashA hard crash of the interpreter, possibly with a core dump
    on Nov 10, 2023
  2. serhiy-storchaka
    self-assigned this
    on Nov 10, 2023
  3. serhiy-storchaka
    added 2 commits that reference this issue on Nov 10, 2023

    pythongh-111942: Fix crashes in TextIOWrapper.reconfigure()

    3d8e144

    gh-111942: Fix crashes in TextIOWrapper.reconfigure() (GH-111976)

    ee06fff
  4. miss-islington
    added 2 commits that reference this issue on Nov 14, 2023

    pythongh-111942: Fix crashes in TextIOWrapper.reconfigure() (pythonGH…

    52d3e54

    pythongh-111942: Fix crashes in TextIOWrapper.reconfigure() (pythonGH…

    c4fc137
  5. serhiy-storchaka
    added 3 commits that reference this issue on Nov 14, 2023

    [3.12] gh-111942: Fix crashes in TextIOWrapper.reconfigure() (GH-111976…

    24216d0

    pythongh-111942: Fix crash in the TextIOWrapper constructor

    bd438e2

    pythongh-111942: Fix SystemError in the TextIOWrapper constructor

    0a85bf3

  6. serhiy-storchaka commented on Nov 14, 2023

    @serhiy-storchaka
    serhiy-storchaka
    on Nov 14, 2023
    MemberAuthor

    Weird. The address sanitizer tests were passed in main and 3.12, but failed in 3.11. And I now can reproduce the failure locally in main.

    The newly added tests exposed a bug in the TextIOWrapper constructor when pass a non-encodable "errors" argument.

  7. vstinner
    added 2 commits that reference this issue on Nov 14, 2023

    pythongh-111942: Fix test_io test_constructor()

    eac3bf5

    gh-111942: Fix SystemError in the TextIOWrapper constructor (#112061)

    9302f05
  8. miss-islington
    added a commit that references this issue on Nov 14, 2023

    pythongh-111942: Fix SystemError in the TextIOWrapper constructor (py…

    8561de9
  9. vstinner
    added 2 commits that reference this issue on Nov 14, 2023

    pythongh-111942: Fix SystemError in the TextIOWrapper constructor (py…

    45075b8

    pythongh-111942: Fix SystemError in the TextIOWrapper constructor (py…

    7f58ab2
  10. serhiy-storchaka
    added 3 commits that reference this issue on Nov 15, 2023

    [3.12] gh-111942: Fix SystemError in the TextIOWrapper constructor (G…

    1445d77

    [3.12] pythongh-111942: Fix SystemError in the TextIOWrapper construc…

    52cafc8

    [3.11] gh-111942: Fix crashes in TextIOWrapper.reconfigure() (GH-111976…

    e2421a3
  11. serhiy-storchaka
    closed this as completedon Nov 15, 2023

  12. vstinner commented on Nov 15, 2023

    @vstinner
    vstinner
    on Nov 15, 2023
    Member

    Nice thanks, thanks.

  13. aisk
    added 2 commits that reference this issue on Feb 11, 2024

    pythongh-111942: Fix crashes in TextIOWrapper.reconfigure() (pythonGH…

    e6d29f1

    pythongh-111942: Fix SystemError in the TextIOWrapper constructor (py…

    8d3b7eb
  14. Glyphack
    added 2 commits that reference this issue on Sep 2, 2024

    pythongh-111942: Fix crashes in TextIOWrapper.reconfigure() (pythonGH…

    ecb4fc1

    pythongh-111942: Fix SystemError in the TextIOWrapper constructor (py…

    80ab1ca

  15. encukou commented on Nov 7, 2024

    @encukou
    encukou
    on Nov 7, 2024
    Member

    There's an issue with the 3.11 backport, in textiowrapper_change_encoding. Main had:

    +    Py_INCREF(errors);
 ...
     Py_SETREF(self->encoding, encoding);
-    Py_SETREF(self->errors, Py_NewRef(errors));
+    Py_SETREF(self->errors, errors);

    but in 3.11 this is:

    +    Py_INCREF(errors);
...
     Py_INCREF(errors);
     Py_SETREF(self->encoding, encoding);
     Py_SETREF(self->errors, errors);

    i.e. there's an extra incref, but it looks -- at least to Git -- like the change that removes Py_NewRef was already applied.

    This was not caught because test_io refleaks tests were ineffective on 3.11.

    I'm preparing a fix.

  16. encukou
    added a commit that references this issue on Nov 7, 2024

    [3.11] pythongh-111942: Remove an extra incref in textiowrapper_chang…

    8e08bf8
  17. pablogsal
    added a commit that references this issue on Nov 8, 2024

    [3.11] gh-111942: Remove an extra incref in textiowrapper_change_enco…

    e33b6fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

topic-IOtype-crashA hard crash of the interpreter, possibly with a core dump

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions