test_tkinter leaks references on Windows #111531

Activity

1. vstinner

   changed the title [-]test_tkinter leaks references[/-] [+]test_tkinter leaks references on Windows[/+] on Oct 31, 2023
2. vstinner commented on Oct 31, 2023

   

   vstinner

   on Oct 31, 2023

   MemberAuthor

   More actions

   git bisect points me to PR #111202 and commit 9bb202a:

   9bb202a1a90ef0edce20c495c9426d9766df11bb is the first bad commit
   commit 9bb202a1a90ef0edce20c495c9426d9766df11bb
   Author: Serhiy Storchaka <storchaka@gmail.com>
   Date:   Tue Oct 24 13:02:12 2023 +0300
   
       gh-75666: Tkinter: add tests for binding (GH-111202)
   
    Lib/test/test_tkinter/test_misc.py | 307 +++++++++++++++++++++++++++++++++++++
    1 file changed, 307 insertions(+)
   
3. terryjreedy commented on Oct 31, 2023

   

   terryjreedy

   on Oct 31, 2023

   Member

   More actions

   @serhiy-storchaka
   f:\dev\3x>python -m test -ugui -R3:3 -m BindTest test_tkinter.test_misc
   ...
   test_tkinter.test_misc leaked [336, 336, 336] references, sum=1008
   test_tkinter.test_misc leaked [151, 151, 151] memory blocks, sum=453
   test_tkinter.test_misc failed (reference leak)

   I am running experiments to see which individual tests leak.
4. serhiy-storchaka

   self-assigned this

   on Oct 31, 2023
5. serhiy-storchaka

   added a commit that references this issue on Oct 31, 2023

   pythongh-111531: Tkinter: fix reference leaks in bind_class() and bin…

   ...

   56d5a4a
6. terryjreedy commented on Oct 31, 2023

   

   terryjreedy

   on Oct 31, 2023

   Last edited by terryjreedy

   Member

   More actions

   I initially commented out blocks, then changed the -m arg to a test name and checked for only 1 match.
   Leaks are pretty well spread out. Results, possibly with errors:
   test_??? name(s): references, blocks

   bind, unbind, unbind2: 6, 0
   rebind, bind_class: 30,16
   unbind_class: 30, 8
   bind_class_rebind: 46, 18
   bind_all: 30, 18
   bind_tags: 0, 0
   bind_events: 102, 59
   unbind_all: 38, 20
   bind_all_rebind: 53, 20
7. serhiy-storchaka commented on Oct 31, 2023

   

   serhiy-storchaka

   on Oct 31, 2023

   Member

   More actions

   Thank you for your report Victor. It is not only on Windows.

   I knew that something may be wrong with bind_class() and bind_all(), and was going to open a new issue when found a reproducer, but I did not know that it also causes leaks.
8. serhiy-storchaka commented on Oct 31, 2023

   

   serhiy-storchaka

   on Oct 31, 2023

   Member

   More actions

   Thank you for your tests Terry. Could you please also check if #111533 fixes leaks? I do not see leaks in bind() on Linux, all leaks were in bind_class() and bind_all().
9. serhiy-storchaka

   added a commit that references this issue on Oct 31, 2023

   gh-111531: Tkinter: fix reference leaks in bind_class() and bind_all() (

   ...

   e3353c4
10. miss-islington

    added 2 commits that reference this issue on Oct 31, 2023

    pythongh-111531: Tkinter: fix reference leaks in bind_class() and bin…

    ...

    86eeefa

    pythongh-111531: Tkinter: fix reference leaks in bind_class() and bin…

    ...

    9a72e3a
11. serhiy-storchaka

    added

    topic-tkinter

    on Oct 31, 2023
12. serhiy-storchaka

    added 2 commits that reference this issue on Oct 31, 2023

    [3.11] gh-111531: Tkinter: fix reference leaks in bind_class() and bi…

    ...

    c66f0be

    [3.12] gh-111531: Tkinter: fix reference leaks in bind_class() and bi…

    ...

    dde5a99
13. serhiy-storchaka

    closed this as completedon Oct 31, 2023
14. vstinner commented on Oct 31, 2023

    

    vstinner

    on Oct 31, 2023

    MemberAuthor

    More actions

    Oh, that was a quick fix 👍

    👍React with 👍1Reacted by Terry Jan Reedy
15. FullteaR

    added a commit that references this issue on Nov 3, 2023

    pythongh-111531: Tkinter: fix reference leaks in bind_class() and bin…

    ...

    391eef4
16. aisk

    added a commit that references this issue on Feb 11, 2024

    pythongh-111531: Tkinter: fix reference leaks in bind_class() and bin…

    ...

    fccbbc5
17. Glyphack

    added a commit that references this issue on Sep 2, 2024

    pythongh-111531: Tkinter: fix reference leaks in bind_class() and bin…

    ...

    8f4cc54