text_encoding() is missing from io.__all__

Bug report

Bug description:

The public io.text_encoding() function is missing from io.__all__.

>>> import io
>>> "text_encoding" in io.__all___
False

CPython versions tested on:

3.10, 3.11, 3.12

Operating systems tested on:

macOS

Linked PRs

@methane

The function was added in #19481, by @methane. It looks to me like this was just an accidental omission, rather than something that's been deliberately excluded from __all__. Want to make a PR to add it? :)

Possibly we could also add a test to Lib/test/test_io.py similar to this one, so that we assert that all public module members are included in __all__:

cpython/Lib/test/test_inspect/test_inspect.py

Lines 125 to 126 in b0699aa

    
           def test__all__(self): 
        
               support.check__all__(self, inspect, not_exported=("modulesbyfile",))

gh-111356: io: Add missing documented objects to io.__all__ (#111370)

pythongh-111356: io: Add missing documented objects to io.__all__ (py…

gh-111356: io: Add missing documented objects to io.__all__ (GH-111370)

Fixed and backported, thanks for the issue!

pythongh-111356: io: Add missing documented objects to io.__all__ (py…

Navigation Menu

Repository navigation

text_encoding() is missing from io.all #111356

Bug report

Bug description:

CPython versions tested on:

Operating systems tested on:

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	def test__all__(self):
	support.check__all__(self, inspect, not_exported=("modulesbyfile",))

text_encoding() is missing from io.__all__ #111356

Description

Bug report

Bug description:

CPython versions tested on:

Operating systems tested on:

Linked PRs

Activity

AlexWaygood commented on Oct 26, 2023

hugovk commented on Dec 11, 2023

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

text_encoding() is missing from io.all #111356