Skip to content

remove hacks in genobject.c #111354

Closed
Closed
remove hacks in genobject.c#111354
Assignees
iritkatriel
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)

Description

@iritkatriel
iritkatriel
opened on Oct 26, 2023

Refactor Objects/genobject.c to get rid of these hacks/issues:

  • gen_close accesses instr_ptr - 1
  • _PyGen_yf peeks into the execution stack
  • Comparisons with enum values
  • result arg reused in gen_send_ex2 for two different purposes (one of which is not the result)

Linked PRs

Activity

  1. iritkatriel
    self-assigned this
    on Oct 26, 2023
  2. iritkatriel
    added 2 commits that reference this issue on Oct 26, 2023

    pythongh-111354: define names for RESUME oparg values

    d6eaf2c

    gh-111354: define names for RESUME oparg values (#111365)

    a0c414c
  3. iritkatriel
    changed the title [-]hacks in gen_close[/-] [+]remove hacks in gen_close[/+] on Oct 26, 2023
  4. iritkatriel
    added
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    on Oct 26, 2023
  5. iritkatriel
    added 2 commits that reference this issue on Nov 2, 2023

    gh-111354: simplify detection of RESUME after YIELD_VALUE at except-d…

    52cc4af

    pythongh-111354: Simplify _PyGen_yf by moving some of its work to the…

    0b37841
  6. FullteaR
    added a commit that references this issue on Nov 3, 2023

    pythongh-111354: simplify detection of RESUME after YIELD_VALUE at ex…

    62f9e8b
  7. iritkatriel
    added a commit that references this issue on Nov 3, 2023

    gh-111354: Simplify _PyGen_yf by moving some of its work to the compi…

    d49aba5
  8. iritkatriel
    changed the title [-]remove hacks in gen_close[/-] [+]remove hacks in genobject.c[/+] on Nov 3, 2023
  9. iritkatriel
    added a commit that references this issue on Nov 9, 2023

    gh-111354: remove comparisons with enum values, variable reuse, unuse…

    30ec968

  10. hugovk commented on Nov 9, 2023

    @hugovk
    hugovk
    on Nov 9, 2023
    Member

    Closing as it looks like the relevant PRs have been merged, please re-open if still needed.

  11. hugovk
    closed this as completedon Nov 9, 2023
  12. aisk
    added 4 commits that reference this issue on Feb 11, 2024

    pythongh-111354: define names for RESUME oparg values (python#111365)

    7edc25e

    pythongh-111354: simplify detection of RESUME after YIELD_VALUE at ex…

    21ec8af

    pythongh-111354: Simplify _PyGen_yf by moving some of its work to the…

    a248d0d

    pythongh-111354: remove comparisons with enum values, variable reuse,…

    881ecbb
  13. Glyphack
    added 4 commits that reference this issue on Sep 2, 2024

    pythongh-111354: define names for RESUME oparg values (python#111365)

    6c87cac

    pythongh-111354: simplify detection of RESUME after YIELD_VALUE at ex…

    40e08f3

    pythongh-111354: Simplify _PyGen_yf by moving some of its work to the…

    b4ac161

    pythongh-111354: remove comparisons with enum values, variable reuse,…

    2af823b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions