You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tried on my Linux (WSL) and x86 MacBook, won't reproduce. The test itself should not even execute the newly added code. The error seems weird too.
However, the ARM64 MacOS buildbot did seem to fail test_signal after this commit. It would be nice to narrow this down and see what could be the issue. For example, will it fail with ./python -m test test_signal -m test_stress_modifying_handlers
I don't think test_stress_modifying_handlers could trigger the issue as the newly added code should not matter. It's possible that there's some dependency on other tests somehow clearing the interpreter states. I don't have any theories yet for what could happen (or if this is a real issue caused by this specific commit).
I am able to repro this on my Mac on the commit before 1e3460d. So this is not introduced by the commit mentioned. (which makes sense because the only line of code committed is not executed during the test).
I am able to repro this on my Mac on the commit before 1e3460d. So this is not introduced by the commit mentioned. (which makes sense because the only line of code committed is not executed during the test).
Yes, after some investigation I came to the same conclusions. Sorry for the false accusation.
Activity
Eclips4 commentedon Oct 12, 2023
Bisected to 1e3460d
cc @gaogaotiantian @markshannon
gaogaotiantian commentedon Oct 12, 2023
Tried on my Linux (WSL) and x86 MacBook, won't reproduce. The test itself should not even execute the newly added code. The error seems weird too.
However, the ARM64 MacOS buildbot did seem to fail
test_signalafter this commit. It would be nice to narrow this down and see what could be the issue. For example, will it fail with./python -m test test_signal -m test_stress_modifying_handlersEclips4 commentedon Oct 12, 2023
Interesting. I no longer can reproduce it :(Traceback:
gaogaotiantian commentedon Oct 12, 2023
I don't think
test_stress_modifying_handlerscould trigger the issue as the newly added code should not matter. It's possible that there's some dependency on other tests somehow clearing the interpreter states. I don't have any theories yet for what could happen (or if this is a real issue caused by this specific commit).gaogaotiantian commentedon Oct 12, 2023
Okay let me see if I could repro on Linux.
gaogaotiantian commentedon Oct 12, 2023
I am able to repro this on my Mac on the commit before 1e3460d. So this is not introduced by the commit mentioned. (which makes sense because the only line of code committed is not executed during the test).
chgnrdv commentedon Oct 12, 2023
See also #110017 #110083
Eclips4 commentedon Oct 13, 2023
Yes, after some investigation I came to the same conclusions. Sorry for the false accusation.
Thanks! That's looks like duplicate of #110017.