You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
--disable-gil test failures due to ABI flag #110119
[test_cppext] Resolving this failure will require updating pip and our bundled pip version. In the meantime, I will skip this test on --disable-gil builds.
If pip is fixed, can the test upgrade pip if running NoGIL Python, as a temporary workaround?
Pip's not fixed yet, but that might be possible once it's fixed. I just put up a PR pypa/packaging#728 to update packaging.tags and then that would need to be pulled into pip's vendored copy of packaging.
Activity
pythongh-110119: Temporarily skip test_cppext on --disable-gil builds.
gh-110119: Temporarily skip test_cppext on --disable-gil builds. (#11…
pythongh-110119: Fix test_importlib `--disable-gil` Windows test fail…
gh-110119: Fix test_importlib `--disable-gil` Windows test failures (#…
colesbury commentedon Oct 5, 2023
These are fixed now. The Windows buildbot needed to not be run from the "Developer Command Prompt for VS 2022".
colesbury commentedon Oct 5, 2023
Oops I was looking at the wrong green icon.
vstinner commentedon Oct 5, 2023
If pip is fixed, can the test upgrade pip if running NoGIL Python, as a temporary workaround?
colesbury commentedon Oct 5, 2023
Pip's not fixed yet, but that might be possible once it's fixed. I just put up a PR pypa/packaging#728 to update packaging.tags and then that would need to be pulled into pip's vendored copy of packaging.
vstinner commentedon Oct 6, 2023
Until pip is fixed, sure, you can skip test_cppext on NoGIL build.
colesbury commentedon Oct 6, 2023
The Windows test looks like it's passing now.
Revert "pythongh-110119: Temporarily skip test_cppext on --disable-gi…
pythongh-110119: Temporarily skip test_cppext on --disable-gil builds. (
pythongh-110119: Fix test_importlib `--disable-gil` Windows test fail…