Repository navigation
Tests: remove C API tests using @requires_legacy_unicode_capi()? #109050
Description
The @test.support.requires_legacy_unicode_capi() decorators uses from _testcapi import unicode_legacy_string, but this module attribute has been remove since Python 3.12 by commit f9c9354, and so all tests using the decorator are now always skipped.
Should we now remove tests using @requires_legacy_unicode_capi() decorator? Or are these tests kept on purpose?
For example, this test is now always skipped:
$ ./python -m test test_capi -m test.test_capi.test_getargs.String_TestCase.test_Z -v
test_Z (test.test_capi.test_getargs.String_TestCase.test_Z) ... skipped 'requires legacy Unicode C API'
See also issue #92536 and PEP 623: Remove wstr from Unicode.
Activity
pythongh-109050: Remove remaining tests for legacy Unicode C API
serhiy-storchaka commentedon Sep 7, 2023
I have examined them all, and they do not contain anything that could be tested. The fact that particular format units are errors is already tested in other tests.
gh-109050: Remove remaining tests for legacy Unicode C API (GH-109068)