gettext: remove unecessary test cases testing single/double quotes

Tests for the gettext module include cases which test both single and double quotes:

Lines 167 to 173 in de51ded

    
           def test_double_quotes(self): 
        
               eq = self.assertEqual 
        
               # double quotes 
        
               eq(_("albatross"), 'albatross') 
        
               eq(_("mullusk"), 'bacon') 
        
               eq(_(r"Raymond Luxury Yach-t"), 'Throatwobbler Mangrove') 
        
               eq(_(r"nudge nudge"), 'wink wink')

As the comment below suggests, these are not needed to properly test gettext as we are only testing translation lookup. The distinction between single and double quotes would be relevant for testing string extraction but that is not part of gettext. I suggest we remove these test cases.

cpython/Lib/test/test_gettext.py

Lines 10 to 13 in de51ded

    
           # TODO: 
        
           #  - Add new tests, for example for "dgettext" 
        
           #  - Remove dummy tests, for example testing for single and double quotes 
        
           #    has no sense, it would have if we were testing a parser (i.e. pygettext)

Linked PRs

It is not so simply. Yes, the comment suggests to remove these tests, but they should be not syply removed, but replaced with proper tests for pygettext.

So I suggest to leave the tests and the comment as a reminder.

If that's the case, would it not make more sense to remove the tests and just update the comment then? So we keep the reminder but not the unnecessary tests

FWIW, I have a PR which adds more tests to pygettext as well: #108173 Feel free to have a look :)

@serhiy-storchaka

Now that tests have been added to pygettext, perhaps it's time to revisit this? @serhiy-storchaka

Sure.

gh-107510: gettext: Remove unnecessary tests (GH-127965)

Can this be closed? They have been removed and replaced.

Navigation Menu

Repository navigation

gettext: remove unecessary test cases testing single/double quotes #107510

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	def test_double_quotes(self):
	eq = self.assertEqual
	# double quotes
	eq(_("albatross"), 'albatross')
	eq(_("mullusk"), 'bacon')
	eq(_(r"Raymond Luxury Yach-t"), 'Throatwobbler Mangrove')
	eq(_(r"nudge nudge"), 'wink wink')

	# TODO:
	# - Add new tests, for example for "dgettext"
	# - Remove dummy tests, for example testing for single and double quotes
	# has no sense, it would have if we were testing a parser (i.e. pygettext)

gettext: remove unecessary test cases testing single/double quotes #107510

Description

Linked PRs

Activity

serhiy-storchaka commented on Oct 8, 2023

tomasr8 commented on Oct 8, 2023

tomasr8 commented on Oct 9, 2023

tomasr8 commented on Dec 14, 2024

serhiy-storchaka commented on Dec 14, 2024

StanFromIreland commented on Feb 16, 2025

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions