Skip to content

C API: Rename _PyUnstable_GetUnaryIntrinsicName() to PyUnstable_GetUnaryIntrinsicName()? #107149

Description

@vstinner

Python 3.13 added _PyUnstable_GetUnaryIntrinsicName() and _PyUnstable_GetBinaryIntrinsicName() to the C API. I don't get the _PyUnstable prefix: PEP 689 – Unstable C API tier uses PyUnstable_ prefix.

Is it just a typo, or is the API private on purpose? If it's private, why does its name look like as if it's part of the Unstable C API?

cc @brandtbucher @iritkatriel @encukou

Linked PRs

Activity

  1. added 3 commits that reference this issue on Aug 24, 2023
  2. iritkatriel commented on Aug 28, 2023

    @iritkatriel
    Member

    I doubt there was a reason for the _. Probably just a habit.

  3. added 6 commits that reference this issue on Aug 28, 2023
  4. vstinner commented on Aug 31, 2023

    @vstinner
    MemberAuthor

    At the end, all APIs discussed here are public and exposed with the PyUnstable prefix in the public C API (in Include/cpython/).

  5. encukou commented on Aug 31, 2023

    @encukou
    Member

    Unstable API needs documentation and tests.

  6. 2 remaining items

  7. vstinner commented on Nov 8, 2023

    @vstinner
    MemberAuthor

    @erlend-aasland:

    Perhaps #105481 (which added the APIs in question) should be reopened instead.

    Ok, I closed this issue and reopened gh-105481 instead.

  8. iritkatriel commented on Nov 12, 2023

    @iritkatriel
    Member

    @erlend-aasland:

    Perhaps #105481 (which added the APIs in question) should be reopened instead.

    Ok, I closed this issue and reopened gh-105481 instead.

    It's not easy to see on that issue what you mean (which unstable APIs? That issue contained several large PRs that change many things). I think it actually works better to finish it off on this issue or create a new one than to report a large old issue.

  9. iritkatriel commented on Nov 12, 2023

    @iritkatriel
    Member

    Also, PyUnstable_ExecutableKinds was not added in #105481.

  10. iritkatriel commented on Nov 13, 2023

    @iritkatriel
    Member

    Reopening. See #105481 (comment).

  11. added 2 commits that reference this issue on Nov 13, 2023
  12. added a commit that references this issue on Nov 14, 2023
  13. vstinner commented on Dec 15, 2023

    @vstinner
    MemberAuthor

    Reopening. See #105481 (comment).

    Change implemented by 36aab34. I close again the issue.

  14. added a commit that references this issue on Feb 11, 2024
  15. added a commit that references this issue on Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions