Skip to content

selector _BaseSelectorImpl._key_from_fd reimplements .get() #106554

Description

@bdraco

selector _BaseSelectorImpl._key_from_fd reimplements .get()

def _key_from_fd(self, fd):

This internal method isn't documented https://docs.python.org/3/library/selectors.html which means it likely can be replaced with .get() which would reduce runtime in the select loops

current:
Screenshot 2023-07-08 at 3 32 38 PM

removed:
Screenshot 2023-07-08 at 3 32 34 PM

Linked PRs

Activity

  1. added a commit that references this issue on Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions