New warning: ‘value’ may be used uninitialized in this function [-Wmaybe-uninitialized] #105673

Activity

1. sobolevn

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   testsTests in the Lib/test dirTests in the Lib/test dir

   interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)

   on Jun 12, 2023
2. sobolevn

   self-assigned this

   on Jun 12, 2023
3. sobolevn

   added a commit that references this issue on Jun 12, 2023

   pythongh-105673: Fix `‘value’ may be used uninitialized in this funct…

   ...

   5ec5d84
4. sobolevn commented on Jun 12, 2023

   

   sobolevn

   on Jun 12, 2023

   MemberAuthor

   More actions

   Better output (greppable and more precise):

                   -o Python/sysmodule.o ./Python/sysmodule.c
   ./Python/sysmodule.c:3390:13: warning: variable 'value' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
           if (name == NULL) {
               ^~~~~~~~~~~~
   ./Python/sysmodule.c:3407:16: note: uninitialized use occurs here
       Py_XDECREF(value);
                  ^~~~~
   ./Include/object.h:792:52: note: expanded from macro 'Py_XDECREF'
   #  define Py_XDECREF(op) Py_XDECREF(_PyObject_CAST(op))
                                                      ^~
   ./Include/object.h:178:49: note: expanded from macro '_PyObject_CAST'
   #define _PyObject_CAST(op) _Py_CAST(PyObject*, (op))
                                                   ^~
   ./Include/pyport.h:24:38: note: expanded from macro '_Py_CAST'
   #define _Py_CAST(type, expr) ((type)(expr))
                                        ^~~~
   ./Python/sysmodule.c:3390:9: note: remove the 'if' if its condition is always false
           if (name == NULL) {
           ^~~~~~~~~~~~~~~~~~~
   ./Python/sysmodule.c:3383:13: warning: variable 'value' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
           if (name == NULL) {
               ^~~~~~~~~~~~
   ./Python/sysmodule.c:3407:16: note: uninitialized use occurs here
       Py_XDECREF(value);
                  ^~~~~
   ./Include/object.h:792:52: note: expanded from macro 'Py_XDECREF'
   #  define Py_XDECREF(op) Py_XDECREF(_PyObject_CAST(op))
                                                      ^~
   ./Include/object.h:178:49: note: expanded from macro '_PyObject_CAST'
   #define _PyObject_CAST(op) _Py_CAST(PyObject*, (op))
                                                   ^~
   ./Include/pyport.h:24:38: note: expanded from macro '_Py_CAST'
   #define _Py_CAST(type, expr) ((type)(expr))
                                        ^~~~
   ./Python/sysmodule.c:3383:9: note: remove the 'if' if its condition is always false
           if (name == NULL) {
           ^~~~~~~~~~~~~~~~~~~
   ./Python/sysmodule.c:3378:27: note: initialize the variable 'value' to silence this warning
       PyObject *name, *value;
                             ^
                              = NULL
   
5. erlend-aasland

   added a commit that references this issue on Jun 12, 2023

   gh-105673: Fix uninitialized warning in sysmodule.c (#105674)

   ...

   a8d69fe
6. miss-islington

   added 2 commits that reference this issue on Jun 12, 2023

   pythongh-105673: Fix uninitialized warning in sysmodule.c (pythonGH-1…

   ...

   ef32a01

   pythongh-105673: Fix uninitialized warning in sysmodule.c (pythonGH-1…

   ...

   8cc1851
7. erlend-aasland

   added 2 commits that reference this issue on Jun 12, 2023

   [3.11] gh-105673: Fix uninitialized warning in sysmodule.c (GH-105674) (

   ...

   171aa08

   [3.12] gh-105673: Fix uninitialized warning in sysmodule.c (GH-105674) (

   ...

   0b305e8
8. sunmy2019

   closed this as completedon Jun 12, 2023