Skip to content

Consider not consuming all the buffer in one go in the tokenizer module #105069

Description

@pablogsal

Seems that some tools were relying on the implementation detail that the readline-like callable that is provided to functions in the tokenize module is called as tokens are emitted and not consumed in one go. Although this was never part of the contract and technically we don't need to change, it would make the implementation more efficient as we don't need to hold the entire input in memory at the same time and we won't break these tools.

Linked PRs

Activity

  1. pablogsal commented on May 29, 2023

    @pablogsal
    MemberAuthor
  2. added 15 commits that reference this issue on May 29, 2023
  3. added a commit that references this issue on May 30, 2023
  4. added a commit that references this issue on May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions