Repository navigation
test_exceptions are leaked #104454
Description
Activity
More specifically:
% ./python.exe -m test -R3:3 test_exceptions -m testAttributes Raised RLIMIT_NOFILE: 256 -> 1024 0:00:00 load avg: 3.46 Run tests sequentially 0:00:00 load avg: 3.46 [1/1] test_exceptions beginning 6 repetitions 123456 ...... test_exceptions leaked [18, 18, 18] references, sum=54 test_exceptions leaked [12, 12, 12] memory blocks, sum=36 test_exceptions failed (reference leak) == Tests result: FAILURE == 1 test failed: test_exceptions Total duration: 256 ms Tests result: FAILUREReacted by Kirill PodoprigoraPR opened to fix. Thanks folks. For my benefit: Why doesn't this test run on PRs?
PR opened to fix. Thanks folks. For my benefit: Why doesn't this test run on PRs?
Running the refleak tests generally takes a while, and isn't necessary for most PRs to CPython. We have a label we can add to PRs to trigger the test being run; in this case, looks like we just forgot to add that label to this PR. It's not a big issue; happens quite often around here :-)
Reacted by Charles Machalow, Gregory P. Smith and Erlend E. Aasland- added a commit that references this issue
on May 13, 2023 thanks for the fix. I missed this leak in review (easy for anyone to miss - our C API is full of sharp edges) and didn't think to trigger the refleaks buildbots on the original PR. it happens, no worries.
- added 2 commits that reference this issue
on May 15, 2023
Tried on last commit
OS: Windows 10
Linked PRs