Repository navigation
Don't define CTYPES_PASS_BY_REF_HACK on aarch64 or riscv64 #103438
Description
There is no need to define CTYPES_PASS_BY_REF_HACK on aarch64 or riscv64. This was a bug in libffi that has since been been fixed, for riscv64 in commit 4b0c358 and for aarch64 in commit e409225.
Activity
FFY00 commentedon Apr 11, 2023
The fix is only available on libfii 3.4.4, for riscv, and 3.4.3, for aarch, so it'd make sense to document this.
ronaldoussoren commentedon Apr 21, 2023
Unconditionally removing the workaround for aarch64 could break builds on macOS that use the system install of libffi, including the installers on our website. Therefore I'm -1 on unconditionally removing the workaround.
Is the need for using the workaround something that can be tested in the configure script?
Even then it would be preferable to continue using the workaround on macOS because we also target older macOS versions that likely will never see this bug fix in the system install of libffi. Using the system install of libffi is desirable due to code signing "tricks" in that build of libffi.