Skip to content

Improve test coverage for the math module #102837

Description

@skirpichev

Sometimes input checks are missing (e.g. L989 of math_1 or L1023 of math_1a), sometimes exceptional cases are not tested (e.g. in fsum), some code is just inaccessible (like L3519 in the perm_comb_small() helper). See attached coverage report (for ./python -m test test_math).

I believe, everything should be tested (except for memory errors and similar special cases).

lcov-report.zip

Linked PRs

Activity

  1. added a commit that references this issue on Mar 20, 2023
  2. added a commit that references this issue on Sep 3, 2023
  3. skirpichev commented on Sep 3, 2023

    @skirpichev
    MemberAuthor

    @hauntsaninja, wait. As I said in the PR thread - there are still some uncovered lines/branches. I think it's worth to keep this issue open until it's fixed completely.

  4. hauntsaninja commented on Sep 3, 2023

    @hauntsaninja
    Contributor

    Ah, missed that since it was early on. Re-opened!

  5. added 2 commits that reference this issue on Sep 28, 2023
  6. added a commit that references this issue on Nov 10, 2023
  7. added a commit that references this issue on Nov 13, 2023
  8. added a commit that references this issue on Nov 13, 2023
  9. added 5 commits that reference this issue on Nov 13, 2023
  10. added a commit that references this issue on Feb 11, 2024
  11. added a commit that references this issue on Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsTests in the Lib/test dirtype-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions