Repository navigation
Check documentation of PyObject_CopyData #102383
Description
Activity
I few lines below, abstract.c has
if (!PyObject_CheckBuffer(dest) || !PyObject_CheckBuffer(src)) { PyErr_SetString(PyExc_TypeError, "both destination and source must be "\ "bytes-like objects");So the 'PyObjects' indeed have to be buffer-like. I don't know the technical details, but I suspect that there is no real bug.
I don't know the technical details, but I suspect that there is no real bug.
There is a bug as the documentation does not match the implementation,
Py_bufferis not a Python object. In this case IMHO the documentation should be fixed.Yes,
PyObject_CheckBufferlooks like so:int PyObject_CheckBuffer(PyObject *obj) { PyBufferProcs *tp_as_buffer = Py_TYPE(obj)->tp_as_buffer; return (tp_as_buffer != NULL && tp_as_buffer->bf_getbuffer != NULL); }
So, there's clearly a bug in the docs. PR is sent :)
Thanks a lot for the report!- added a commit that references this issue
on Mar 3, 2023 - added a commit that references this issue
on Mar 4, 2023
According to the documentation,
PyObject_CopyDatatakes two arguments of typePy_buffer*:cpython/Doc/c-api/buffer.rst
Line 502 in 71db5db
But in the implementation, it actually takes two arguments of
PyObject*:cpython/Objects/abstract.c
Line 613 in 71db5db
Linked PRs
PyObject_CopyDataarePyObject *#102390PyObject_CopyDataarePyObject *(GH-102390) #102401