Skip to content

Refleak after new OrderedDict repr #101747

Closed
Closed
Refleak after new OrderedDict repr#101747
Assignees
sobolevn
Labels
type-bugAn unexpected behavior, bug, or error

Description

@sobolevn
sobolevn
opened on Feb 9, 2023

It is reported by @corona10 that after 790ff6b we have a new refleak:

  • test_ordered_dict
  • test_pprint
  • test_trace

Looks like dcopy = PyDict_Copy((PyObject *)self); is created, but never freed :(

PR is on its way.

Linked PRs

Activity

  1. sobolevn
    added
    type-bugAn unexpected behavior, bug, or error
    on Feb 9, 2023
  2. sobolevn
    self-assigned this
    on Feb 9, 2023

  3. sobolevn commented on Feb 9, 2023

    @sobolevn
    sobolevn
    on Feb 9, 2023
    MemberAuthor

    Local repro: ./python.exe -m test -v test_ordered_dict -R 3:3

    test_ordered_dict leaked [1196, 1194, 1196] references, sum=3586
test_ordered_dict leaked [203, 202, 203] memory blocks, sum=608
test_ordered_dict failed (reference leak)

== Tests result: FAILURE ==

1 test failed:
    test_ordered_dict
  4. sobolevn
    added a commit that references this issue on Feb 9, 2023

    pythongh-101747: Fix refleak in new `OrderedDict` repr

    f8adfe9
  5. rhettinger
    added a commit that references this issue on Feb 10, 2023

    gh-101747: Fix refleak in new `OrderedDict` repr (GH-101748)

    34c50ce
  6. rhettinger
    closed this as not plannedon Feb 10, 2023
  7. rhettinger
    reopened this on Feb 10, 2023
  8. rhettinger
    closed this as completedon Feb 10, 2023
  9. carljm
    added a commit that references this issue on Feb 10, 2023

    Merge branch 'main' into inlinecomp2

    add772e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

type-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions