Repository navigation
[3.11/main] gh-101579 broke binary compatibility #101635
Description
On a system with
GNU C Library (GNU libc) stable release version 2.26
gcc version 10.3.1 20210422 (Red Hat 10.3.1-1) (GCC)
Using precompiled version of numpy (numpy-1.24.2-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl), after cf89c16486a4cc297413e17d32082ec4f389d725 I get:
❯❯❯ import numpy
---------------------------------------------------------------------------
ValueError Traceback (most recent call last)
Cell In[1], line 1
----> 1 import numpy
File /local/home/idoenmez/envs/workbench/lib/python3.11/site-packages/numpy/__init__.py:152
150 from . import fft
151 from . import polynomial
--> 152 from . import random
153 from . import ctypeslib
154 from . import ma
File /local/home/idoenmez/envs/workbench/lib/python3.11/site-packages/numpy/random/__init__.py:180
126 __all__ = [
127 'beta',
128 'binomial',
(...)
176 'zipf',
177 ]
179 # add these for module-freeze analysis (like PyInstaller)
--> 180 from . import _pickle
181 from . import _common
182 from . import _bounded_integers
File /local/home/idoenmez/envs/workbench/lib/python3.11/site-packages/numpy/random/_pickle.py:1
----> 1 from .mtrand import RandomState
2 from ._philox import Philox
3 from ._pcg64 import PCG64, PCG64DXSM
File mtrand.pyx:1, in init numpy.random.mtrand()
ValueError: builtins.bool size changed, may indicate binary incompatibility. Expected 32 from C header, got 24 from PyObject
Works fine if I revert the faulty commit.
cc @mdickinson
Activity
mdickinson commentedon Feb 7, 2023
Hmm, interesting. Thanks for the report! This is something of a false positive from Cython - there was no change to the
boollayout, so there should be no actual binary incompatibility. What changed is thatsys.getsizeofis more accurate than it was previously.I don't think I understand how Cython gets the value
24, though.That said, the fix isn't a particularly important one, so I think we can revert for 3.11. I think the fix should stay in the
mainbranch, though.[-][3.11/main] cf89c16486a4cc297413e17d32082ec4f389d725 broke binary compatibility[/-][+][3.11/main] gh-101579 broke binary compatibility[/+]mdickinson commentedon Feb 7, 2023
The change for 3.11 was reverted in #101638.