Skip to content

Improve pickle protocols coverage in test_slice  #100931

Closed
Closed
Improve pickle protocols coverage in test_slice #100931
Assignees
sobolevn
Labels
testsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Description

@sobolevn
sobolevn
opened on Jan 11, 2023

While working on #100817 I've noticed that slice is only tested with 3 pickle protocols. See

cpython/Lib/test/test_slice.py

Lines 237 to 243 in 8dd2766

def test_pickle(self):
s = slice(10, 20, 3)
for protocol in (0,1,2):
t = loads(dumps(s, protocol))
self.assertEqual(s, t)
self.assertEqual(s.indices(15), t.indices(15))
self.assertNotEqual(id(s), id(t))
I don't think we need to limited supported protocols. Let's test all protocols!

Linked PRs

Activity

  1. sobolevn
    added
    type-bugAn unexpected behavior, bug, or error
    testsTests in the Lib/test dir
    on Jan 11, 2023
  2. sobolevn
    self-assigned this
    on Jan 11, 2023
  3. sobolevn
    added a commit that references this issue on Jan 11, 2023

    pythongh-100931: Test all `pickle` protocols in `test_slice`

    7d7f593
  4. AlexWaygood
    added a commit that references this issue on Jan 11, 2023

    gh-100931: Test all `pickle` protocols in `test_slice` (#100932)

    8795ad1
  5. sobolevn
    added 2 commits that reference this issue on Jan 12, 2023

    [3.10] pythongh-100931: Test all `pickle` protocols in `test_slice` (p…

    eedd3f0

    [3.11] pythongh-100931: Test all `pickle` protocols in `test_slice` (p…

    e52d37b
  6. miss-islington
    added a commit that references this issue on Jan 12, 2023

    [3.10] gh-100931: Test all `pickle` protocols in `test_slice` (GH-100932

    47b1eb9

  7. AlexWaygood commented on Jan 12, 2023

    @AlexWaygood
    AlexWaygood
    on Jan 12, 2023
    Member

    Thanks!

  8. AlexWaygood
    closed this as completedon Jan 12, 2023
  9. miss-islington
    added a commit that references this issue on Jan 12, 2023

    [3.11] gh-100931: Test all `pickle` protocols in `test_slice` (GH-100932

    cb6ff54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

testsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions