Skip to content

Update test_peg_generator to not need distutils & reenable it #100238

Closed
Closed
Update test_peg_generator to not need distutils & reenable it#100238
Labels
testsTests in the Lib/test dir

Description

@encukou
encukou
opened on Dec 14, 2022

distutils was removed from 3.12, as per PEP 632.
test_peg_generator, which uses it, was disabled. It should be updated to not need distutils.

See #92584

Linked PRs

Activity

  1. encukou
    added
    testsTests in the Lib/test dir
    on Dec 14, 2022

  2. ramvikrams commented on Dec 30, 2022

    @ramvikrams
    ramvikrams
    on Dec 30, 2022
    Contributor

    I'd like to work on this I looked through test_peg_generator but I could not find any test that importing distuils

  3. ericsnowcurrently commented on Mar 8, 2023

    @ericsnowcurrently
    ericsnowcurrently
    on Mar 8, 2023
    Member

    @Yhg1s, this feels like a release blocker. Thoughts?

  4. ericsnowcurrently commented on Mar 8, 2023

    @ericsnowcurrently
    ericsnowcurrently
    on Mar 8, 2023
    Member

    @ramvikrams, distutils is used in Tools/peg_generator/pegen/build.py, which I'm guessing is exercised by tests under Lib/test/test_peg_generator. See the comment in Lib/test/test_peg_generator/__init__.py.

  5. ramvikrams commented on Mar 8, 2023

    @ramvikrams
    ramvikrams
    on Mar 8, 2023
    Contributor

    @ramvikrams, distutils is used in Tools/peg_generator/pegen/build.py, which I'm guessing is exercised by tests under Lib/test/test_peg_generator. See the comment in Lib/test/test_peg_generator/init.py.

    Thanks I'll check it

  6. ericsnowcurrently commented on Mar 8, 2023

    @ericsnowcurrently
    ericsnowcurrently
    on Mar 8, 2023
    Member

    FYI, we may want to solve this in a way that can be shared between the c-analyzer and peg_generator tools. See #92584 (comment).

  7. Yhg1s commented on Mar 8, 2023

    @Yhg1s
    Yhg1s
    on Mar 8, 2023
    Member

    Yes, I consider this a release blocker for the betas (#92584 is left open as a release blocker for this reason).

  8. ramvikrams commented on Mar 12, 2023

    @ramvikrams
    ramvikrams
    on Mar 12, 2023
    Contributor

    I looked through the file but I had a question should I replace distutils with setuptools in Tools/peg_generator/pegen/build.py

  9. lysnikolaou
    added 2 commits that reference this issue on May 23, 2023

    pythongh-100238: Use setuptools in peg-generator and reenable tests

    88edfa7

    gh-100238: Use setuptools in peg-generator and reenable tests (#104798)

    afa759f

  10. lysnikolaou commented on May 26, 2023

    @lysnikolaou
    lysnikolaou
    on May 26, 2023
    Member

    Resolved in #104798.

  11. lysnikolaou
    closed this as completedon May 26, 2023
  12. miss-islington
    added a commit that references this issue on May 31, 2023

    pythongh-100238: Use setuptools in peg-generator and reenable tests (p…

    4e73547
  13. lysnikolaou
    added a commit that references this issue on Jul 5, 2023

    [3.12] gh-100238: Use setuptools in peg-generator and reenable tests (G…

    6371029
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsTests in the Lib/test dir

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions