Repository navigation
make sharedinstall does not return failure if install commands fail #100220
Description
Activity
- changed the title
[-]`make sharedinstall` no longer returns failure if install commands fail[/-][+]`make sharedinstall` does not retrn failure if install commands fail[/+]on Dec 13, 2022 - changed the title
[-]`make sharedinstall` does not retrn failure if install commands fail[/-][+]`make sharedinstall` does not return failure if install commands fail[/+]on Dec 13, 2022 - added a commit that references this issue
on Dec 18, 2022 - added a commit that references this issue
on Feb 9, 2023 GH-100328 merged, thanks for the report and patch!
I think we'll pass on backporting this; there haven't been reported problems in this vein before (though the recipes haven't changed much, so the underlying issue does exist in older branches), and there could be some lesser-used recipes that shouldn't use
-ethat we missed.Yeah, I suppose the risk is relatively small, as it affects only a few less frequently used rules.
Bug report
If
make sharedinstallfails to install some Python extensions, the make target wrongly succeeds. For example, I'm seeing:Nevertheless,
make installreturns successfully in this case. This causes major problems for automated builds since they end up with broken Python installs when the make target should have failed.I need to investigate why it's failing but that's a separate issue.
Complete build log (1.2M): dev-lang:python-3.12.0_alpha3:20221207-142002.log
The problem seems to be that the
sharedinstalltargets runs a single shell command and make doesn't check the exit status until its very end.I suspect the same problem may apply to other install rules.
Your environment
Linked PRs