Repository navigation
Add setup.py - #99
Add setup.py#99
Conversation
Mariatta
left a comment
There was a problem hiding this comment.
Thanks @tiran
Can you also update cherry_picker/readme.rst?
I think the section about Setup Info should be updated to have people run venv/bin/pip install .
And then under alternate usage at the top, people can use python cherry_picker ... from an existing cpython directory.
``venv/bin/pip install .`` installs all dependencies and venv/bin/cherry_picker script. Signed-off-by: Christian Heimes <christian@python.org>
|
@Mariatta I have amended the commit and updated the readme as request. I also replaced |
|
Thanks @tiran :) @brettcannon or @ncoghlan: Could one of you review this too please? |
ncoghlan
left a comment
There was a problem hiding this comment.
Looks good to me, although you may want to use the mailing list's email address rather than your personal one.
| license='Apache', | ||
| url='https://github.com/python/core-workflow', | ||
| author='Mariatta Wijaya', | ||
| author_email='mariatta.wijaya@gmail.com', |
There was a problem hiding this comment.
You may want to put core-workflow@mail.python.org as your address here, so folks know to contact the list with any questions, rather than contacting you directly.
There was a problem hiding this comment.
I added @Mariatta 's mail address. We may want to keep it and add maintainer / maintainer_email for contact. After all Marietta wrote the script and deserves credits. :)
There was a problem hiding this comment.
Thanks 😸 Well I've prepared a canned response already "Please file an issue at python/core-workflow"
I'll add the following:
"maintainer": "Python Core Developers",
"maintainer_email": "core-workflow@mail.python.org",
Question: is version metadata not needed? The doc seems to indicate that it's required.
|
Thanks @tiran |
venv/bin/pip install .installs all dependencies andvenv/bin/cherry_picker script.
Signed-off-by: Christian Heimes christian@python.org
Closes #50
Closes #64
Closes #89