Skip to content

Update readme with pip install instructions - #130

Merged
Mariatta merged 3 commits into
python:masterfrom
Mariatta:pip-install
Jun 19, 2017
Merged

Mariatta merged 3 commits into
python:masterfrom
Mariatta:pip-install

Conversation

@Mariatta

@Mariatta Mariatta commented Jun 19, 2017 •

Copy link
Copy Markdown
Member

Closes #114

Comment thread cherry_picker/readme.rst Outdated
(venv) $ python -m pip install cherry_picker

Specify an `upstream` remote in the cloned CPython repository::
Ensure that an ``upstream`` remote is specified in the cloned CPython repository::

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps split this into two steps:

Verify that an ``upstream`` remote is set to the CPython repository::
     $ git remote -v
     ...
     upstream	https://github.com/python/cpython (fetch)
     upstream	https://github.com/python/cpython (push)

If needed, create the ``upstream`` remote::
    $ git remote add upstream https://github.com/python/cpython.git

Comment thread cherry_picker/readme.rst


The cherry picking script assumes that if an `upstream` remote is defined, then
The cherry picking script assumes that if an ``upstream`` remote is defined, then

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps move these 2 sentences before the "verifying upstream remote".

@Mariatta

Copy link
Copy Markdown
Member Author

Thanks @willingc I made the suggested changes.

@willingc willingc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mariatta

@Mariatta
Mariatta merged commit ff2fadb into python:master Jun 19, 2017
@Mariatta
Mariatta deleted the pip-install branch June 19, 2017 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants