Skip to content

Please make Travis CI optional again #377

Closed
Closed
Please make Travis CI optional again#377

Description

@vstinner
vstinner
opened on Oct 8, 2020

Please make Travis CI job optional on Python. The issue #376 prevents to merge PRs even when the Travis CI run succesfully.

For example, python/cpython#22513 was created 5 days ago. The PR lists two Travis CI builds. One is "Queued — Build Created", the other one is "Successful in 16m — Build Passed". Problem: if you click on the two builds... it's the same build: https://travis-ci.com/github/python/cpython/builds/188824091

Travis CI integration in GitHub is sick for several months and I'm tired of trying to fix it. Again, see #376 for the 3rd issue in 6 months.

Activity

  1. vstinner commented on Oct 8, 2020

    @vstinner
    vstinner
    on Oct 8, 2020
    MemberAuthor

    I'm not fully comfortable with having no mandatory Linux job on PRs. One solution would be to make the "Ubuntu (pull_request)" GitHub Action job mandatory.

    What do you think of making the Travis CI job optional and make the Ubuntu job mandatory, at the same time?

    Can this change be done for 3.7, 3.8, 3.9 and master branches? I see the Ubuntu job on my recent 3.7 PR: python/cpython#22578 (backport)

    For Python 3.6, I see GitHub Action jobs, but only @ned-deily is allowed to merge changes on this branch. I'm sure that he will pay a special attention to all CIs before merging anything! Example of recent 3.6 PR: python/cpython#22579 (backport).

    For 3.6, I suggest to just make Travis CI optional.

    @ewdurbin @Mariatta @brettcannon: Who is allowed to make a CI mandatory or optional on the GitHub cpython project?

  2. ewdurbin commented on Oct 8, 2020

    @ewdurbin
    ewdurbin
    on Oct 8, 2020
    Member

    @ewdurbin @Mariatta @brettcannon: Who is allowed to make a CI mandatory or optional on the GitHub cpython project?

    Current organization owners and repository administrators

  3. ewdurbin commented on Oct 8, 2020

    @ewdurbin
    ewdurbin
    on Oct 8, 2020
    Member

    When some consensus is determined, I'm happy to handle this, just mention me again.

  4. brettcannon commented on Oct 8, 2020

    @brettcannon
    brettcannon
    on Oct 8, 2020
    Member

    I strongly support the proposed change.

  5. vstinner commented on Oct 8, 2020

    @vstinner
    vstinner
    on Oct 8, 2020
    MemberAuthor

    Once the change will be applied, I will notify python-committers list as I did last May when Travis CI became mandatory.
    https://mail.python.org/archives/list/python-committers@python.org/message/B6WVI254L7GEOCKUOHZ6XBZD4GCLAIBV/

    In May, Tracis CI looked reliable. Over time, it is getting worse and worse. I'm tired to spending time on trying to fix each Travis CI issue.

  6. ammaraskar commented on Oct 9, 2020

    @ammaraskar
    ammaraskar
    on Oct 9, 2020
    Member

    I'm not fully comfortable with having no mandatory Linux job on PRs. One solution would be to make the "Ubuntu (pull_request)" GitHub Action job mandatory.

    What do you think of making the Travis CI job optional and make the Ubuntu job mandatory, at the same time?

    Given Travis's unreliability and their lack of any visible response or feedback on their forums I think this would be the best option for now. We should definitely have one mandatory Linux job and the Github workflow seems like a good replacement.

  7. Mariatta commented on Oct 9, 2020

    @Mariatta
    Mariatta
    on Oct 9, 2020
    Member

    I also agree with making travisci not required for now.
    I've brought up this issue with GitHub OS Maintainers feedback group. They said:

    "The team responsible for Checks has been looking into this issue, but I'm not sure about a timeline for a fix"

  8. vstinner commented on Oct 10, 2020

    @vstinner
    vstinner
    on Oct 10, 2020
    MemberAuthor

    Given Travis's unreliability and their lack of any visible response or feedback on their forums

    Oh right, I forgot to mention that "Travis CI fails to report build status to GitHub PR" is an old known issue and is frequently reported to the Travis CI community. I didn't see concrete progress over the last months.

  9. vstinner commented on Oct 15, 2020

    @vstinner
    vstinner
    on Oct 15, 2020
    MemberAuthor

    @ewdurbin: I count 3 people in favor of the making Travis CI optional, and no one who wants to keep it as mandatory. Would you mind to make it optional?

  10. ewdurbin commented on Oct 15, 2020

    @ewdurbin
    ewdurbin
    on Oct 15, 2020
    Member

    @vstinner for all branches?

  11. ned-deily commented on Oct 15, 2020

    @ned-deily
    ned-deily
    on Oct 15, 2020
    Member

    @vstinner for all branches?

    Yes, please.

  12. ewdurbin commented on Oct 15, 2020

    @ewdurbin
    ewdurbin
    on Oct 15, 2020
    Member

    Done.

  13. vstinner commented on Oct 16, 2020

    @vstinner
    vstinner
    on Oct 16, 2020
    MemberAuthor

    Done.

    Thanks Ernerst! I announced the change on python-committers:
    https://mail.python.org/archives/list/python-committers@python.org/thread/JR7HIQHVECHPKH2LE46EACN73KCBLVKE/

    Now, should we consider to make the Ubuntu job mandatory, at least on the master branch, to get at least one Linux CI mandatory job?

  14. vstinner commented on Oct 16, 2020

    @vstinner
    vstinner
    on Oct 16, 2020
    MemberAuthor

    This change fixed issue #376.

  15. ned-deily commented on Oct 19, 2020

    @ned-deily
    ned-deily
    on Oct 19, 2020
    Member

    Update: at the Core Dev Virtual Sprint today, the issue of continuing to run Travis at all was discussed with the opinion voiced that, if the Travis CI jobs are now optional and if few people are even looking at them, it would be better to not keep wasting Travis resources to the potential detriment of other projects using Travis. A majority of the current release managers (with no dissensions) and @brettcannon agreed to disable the Travis hooks on all branches - at least until we have reason to believe that the intermittent problems we have been seeing are gone - and that has now been done. So I think we can now close this issue.

  16. ned-deily
    closed this as completedon Oct 19, 2020

  17. terryjreedy commented on Oct 19, 2020

    @terryjreedy
    terryjreedy
    on Oct 19, 2020 via email
    Member

  18. ned-deily commented on Oct 20, 2020

    @ned-deily
    ned-deily
    on Oct 20, 2020
    Member

    It looks like I spoke too soon: Travis checks are still running for PRs. And it looks like we haven't yet made at least one Ubuntu check mandatory as was also discussed elsewhere. Reopening.

  19. ned-deily
    reopened this on Oct 20, 2020

  20. ammaraskar commented on Oct 20, 2020

    @ammaraskar
    ammaraskar
    on Oct 20, 2020
    Member

    Now, should we consider to make the Ubuntu job mandatory, at least on the master branch, to get at least one Linux CI mandatory job?

    Yes please, it looks like there's consensus on this on python-committers as well: https://mail.python.org/archives/list/python-committers@python.org/thread/JR7HIQHVECHPKH2LE46EACN73KCBLVKE/

    Would you mind setting the ubuntu github action to required @ewdurbin?

  21. brettcannon commented on Oct 20, 2020

    @brettcannon
    brettcannon
    on Oct 20, 2020
    Member

    The Travis checks were taken off, so I went ahead and made the "Ubuntu" check required.

    Since that should cover everything, I'm closing this issue.

  22. brettcannon
    closed this as completedon Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions