Skip to content

Link to GitHub PR from bpo emails #35

Description

@Mariatta

When someone creates a pull request that links to a bpo issue, there would be email sent to the issue subscribers / nosy list, for example:

Changes by Mariatta Wijaya <mariatta.wijaya@gmail.com>:


----------
pull_requests: +70
  1. Does 70 here refer to GitHub pull request number 70? (eg Add Travis CI and Codecov badges to README cpython#70)
  2. Instead of a plaintext +70, can it be a link to the said pull request?

Thanks :)

Activity

  1. ezio-melotti commented on Feb 21, 2017

    @ezio-melotti
    Member
    1. The 70 only refers to pull_request item of the tracker, i.e. https://bugs.python.org/pull_request70
      The actual PR number is different, as you can see from the link (in this case is bpo-29481: add versionadded 3.6.1 to typing.Deque docs cpython#107).
    2. These mails are automatically generated, and I'm not aware of a way to change them and insert the link. It should be possible, but probably it's not too straightforward, and it might not be worth the effort.
  2. Mariatta commented on Mar 6, 2017

    @Mariatta
    MemberAuthor

    Thanks for the info, @ezio-melotti
    If there's no straightforward way to do it, then let's not bother for now.

  3. ncoghlan commented on Apr 1, 2017

    @ncoghlan
    Contributor

    I'm reopening this, as the status quo is genuinely confusing when one PR references multiple issues - each email has a different numeric identifier for the PR, even if they're all related to the same PR. (I'd be surprised if it ever happens again to the degree it did when the draft NEWS generation PR was closed, but I'd also be surprised if it never happens at all)

    Rather than attempting to customise these emails directly, would it possible to turn off email notifications for PR additions and state changes entirely, and instead inject more meaningful comments describing the state change?

  4. ezio-melotti commented on Apr 1, 2017

    @ezio-melotti
    Member

    If you want to continue the discussion I'd suggest moving it to the meta-tracker:
    http://psf.upfronthosting.co.za/roundup/meta/issue624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions