You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Should blurb and cherry_picker move to their own repos? #329
When we started with blurb and cherry-picker, they were simply command line tools and not published to PyPI.
Now blurb and cherry-picker are in PyPI independently, each have their own chaneglog, their own License (blurb is BSD, cherry-picker is Apache), their own readme, their own owners; perhaps they should be split into their own repos?
One inconvenience I encountered while both are under the same repo, is https://github.com/python/core-workflow/issues/313. I wanted to move cherry-picker's documentation to readthedocs, but readthedocs support one documentation per repo.
I'm also wondering how having two packages in the same repo affect GitHub's dependency graph 🤔 Perhaps there is no real dependency other than blurb-it depends on blurb, and miss-islington depends on cherry-picker.
Honestly, I think we should split the projects out and then shut down the repo. This was partially an experiment to see if it would work out better than core-workflow@ and I don't it provides much at this point beyond a place for cherry-picker and blurb. 😄
Ok, I can look into moving cherry-picker out. Don't know about shutting down repo. I've been telling people to file general workflow-related issues here, the ones not specific to bots. Just need a different place for that purpose..
@Mariatta I would say issues should potentially be brought up on discuss.python.org, but we can worry about what to do after cherry-picker and blurb move.
While I prefer using discourse for discussions over mailing lists, sometimes we need issues to reflect tasks/bugs where we can assign people, and close when the task is done. Discourse doesn't seem to be a natural place for this.
I can't even close my own Discourse post, an admin needs to do it.
So I think this repo is still needed for core-workflow "issues" 🤔
Reacted by Carol Willing, Kyle Stanley, Hugo van Kemenade and Alyssa Coghlan
For the test files (.github/, .pre-commit-config.yaml etc) I just copied those over, I don't think the history on those is so important. And then updated file structure for the new repo.
This is great to see, thanks @hugovk ! Been wanting to help see this happen for a long time.
Might be nice if we could ask @larryhastings if we could remove the first and last two lines of the LICENSE.txt file that aren't actually part of the BSD-3 license itself (the blurb version, the seemingly redundant mention of it being under the blurb package, and the ancillary mention of the PSF contributor agreement) so the license gets properly detected as an OSI-approved open source / FSF-approved free software license.
Alternatively, we could relicense it as Apache-2.0, as Cherry-Picker was and as the PSF contributor agreement (explicitly mentioned in the current license) gives the right to (and thus the current license text explicitly allows, though it is also permitted by the terms of BSD-3 so long as the original license text is retained in e.g. NOTICE.txt).
Also could be something to ping the new legal counsel on.
Activity
asvetlov commentedon May 30, 2019
I think the separation makes sense.
brettcannon commentedon May 30, 2019
Honestly, I think we should split the projects out and then shut down the repo. This was partially an experiment to see if it would work out better than core-workflow@ and I don't it provides much at this point beyond a place for cherry-picker and blurb. 😄
Mariatta commentedon May 30, 2019
Ok, I can look into moving cherry-picker out. Don't know about shutting down repo. I've been telling people to file general workflow-related issues here, the ones not specific to bots. Just need a different place for that purpose..
brettcannon commentedon May 30, 2019
@Mariatta I would say issues should potentially be brought up on discuss.python.org, but we can worry about what to do after cherry-picker and blurb move.
@larryhastings FYI
Mariatta commentedon May 30, 2019
I've created a project board for things need doing: https://github.com/python/core-workflow/projects/2
Mariatta commentedon Jun 5, 2019
@larryhastings Can I go ahead and move blurb out? Or you want to do this yourself?
Mariatta commentedon Jun 5, 2019
While I prefer using discourse for discussions over mailing lists, sometimes we need issues to reflect tasks/bugs where we can assign people, and close when the task is done. Discourse doesn't seem to be a natural place for this.
I can't even close my own Discourse post, an admin needs to do it.
So I think this repo is still needed for core-workflow "issues" 🤔
hugovk commentedon Mar 20, 2024
I agree we should move blurb to its own repo, and keep this one for issues.
Shall we do this before setting up automated deploys for blurb in this repo? python/blurb#4
Mariatta commentedon Mar 20, 2024
Yes I would suggest moving it out first so we don't need to repeat the process later on.
hugovk commentedon Mar 20, 2024
I've made a blurb repo on my account: https://github.com/hugovk/blurb
I followed the instructions at https://help.github.com/en/articles/splitting-a-subfolder-out-into-a-new-repository (from the project https://github.com/python/core-workflow/projects/2) to filter the blurb directory preserving history.
For the test files (
.github/,.pre-commit-config.yamletc) I just copied those over, I don't think the history on those is so important. And then updated file structure for the new repo.Next steps:
CAM-Gerlach commentedon Mar 20, 2024
This is great to see, thanks @hugovk ! Been wanting to help see this happen for a long time.
Might be nice if we could ask @larryhastings if we could remove the first and last two lines of the
LICENSE.txtfile that aren't actually part of the BSD-3 license itself (the blurb version, the seemingly redundant mention of it being under the blurb package, and the ancillary mention of the PSF contributor agreement) so the license gets properly detected as an OSI-approved open source / FSF-approved free software license.Alternatively, we could relicense it as Apache-2.0, as Cherry-Picker was and as the PSF contributor agreement (explicitly mentioned in the current license) gives the right to (and thus the current license text explicitly allows, though it is also permitted by the terms of BSD-3 so long as the original license text is retained in e.g.
NOTICE.txt).Also could be something to ping the new legal counsel on.
hugovk commentedon Mar 25, 2024
Update: after a positive response on Discourse, I've asked the steering council for permission to transfer: python/steering-council#240.
hugovk commentedon Mar 27, 2024
Update: The SC approves, I've moved the repo to https://github.com/python/blurb and opened #533 and python/devguide#1302.
Next steps:
hugovk commentedon Mar 28, 2024
Please could @python/organization-owners add Dependabot, CLA bot and https://pre-commit.ci/ to https://github.com/python/blurb?
Also double check the core team has merge access like in other similar repos (for example, this one and https://github.com/python/cherry-picker).
ambv commentedon Mar 28, 2024
On it.
ambv commentedon Mar 28, 2024
Dependabot enabled.
CLA bot enabled.
pre-commit.ci enabled.
python/core team members added as writers.
hugovk commentedon Mar 28, 2024
@ambv Thank you!
@Mariatta Thank you for the project: https://github.com/python/core-workflow/projects/2?query=is%3Aopen+sort%3Aupdated-desc It was very helpful doing the transfer 👍
We're almost done here. Remaining:
The (five-year-old) project card listed:
Notify:
In 2024, I think we only need:
hugovk commentedon Apr 4, 2024
Done: https://discuss.python.org/t/blurb-now-lives-at-python-blurb/50239
I think that's everything, thanks all!
✨🏡 https://github.com/python/blurb ✨