Travis has an issue with the C build? #218

Activity

1. matrixise commented on Feb 7, 2018

   

   matrixise

   on Feb 7, 2018

   Last edited by matrixise

   MemberAuthor

   More actions

   Here is my test:
   bpo-1100942 is the branch of this PR: python/cpython#5578

   #!/usr/bin/env bash
   
   files_changed=$(git diff --name-only bpo-1100942) 
   
   echo $(git diff --name-only bpo-1100942 | grep -vE '(\.rst$)|(^Doc)|(^Misc)')
   has_code=$(git diff --name-only bpo-1100942 | grep -qvE '(\.rst$)|(^Doc)|(^Misc)')
   
   if ! $has_code
   then
       echo "HasCode: Only docs updated"
   else
       echo "HasCode: We can update"
   fi
   
   if ! echo $files_changed | grep -qvE '(\.rst$)|(^Doc)|(^Misc)'
   then
       echo "FilesChanged: Only docs updated"
   else
       echo "FilesChanged: We can update"                                                        
   fi

   and the output:

   Lib/_strptime.py Lib/datetime.py Lib/test/datetimetester.py Modules/_datetimemodule.c
   HasCode: We can update
   FilesChanged: Only docs updated
   

   When I execute the code of Travis, I have the result, Only docs updated but when I execute the git diff with the grep command, I have the right result.
2. matrixise commented on Feb 7, 2018

   

   matrixise

   on Feb 7, 2018

   MemberAuthor

   More actions

   @brettcannon I have changed the condition with a flat condition, without any variable and the worker of Travis runs the tests

   Here is my PR for review https://github.com/python/cpython/pull/5580/files

   my 2cents...
3. berkerpeksag commented on Feb 8, 2018

   

   berkerpeksag

   on Feb 8, 2018

   Member

   More actions

   python/cpython@b2ec361 (see #14 (comment) for details) might be the culprit. @ammaraskar do you have some time to investigate this?
4. ammaraskar commented on Feb 8, 2018

   

   ammaraskar

   on Feb 8, 2018

   Member

   More actions

   Oh this is most likely just a quoting issue around the variable, trying changing the line to:

   if ! echo "$files_changed" | grep -qvE '(\.rst$)|(^Doc)|(^Misc)'

   instead of

   if ! echo $files_changed | grep -qvE '(\.rst$)|(^Doc)|(^Misc)'
5. matrixise commented on Feb 8, 2018

   

   matrixise

   on Feb 8, 2018

   MemberAuthor

   More actions

   I have created this issue https://bugs.python.org/issue32802 and the associated PR python/cpython#5589 . This PR can be back ported to 3.6 & 3.7
6. Mariatta commented on Feb 8, 2018

   

   Mariatta

   on Feb 8, 2018

   Member

   More actions

   Thanks @matrixise! Good catch and thanks for fixing.
   I've merged that PR and now waiting for the backports to be finished.

   I wonder if other open PRs should be rebased to include the change in python/cpython#5589?
7. ammaraskar commented on Feb 8, 2018

   

   ammaraskar

   on Feb 8, 2018

   Last edited by ammaraskar

   Member

   More actions

   I wonder if other open PRs should be rebased to include the change in python/cpython#5589?

   A rebase won't be required, travis pulls in latest changes and applies the changes to the latest codebase (which should include the new travis.yml). A rebuild should do.

   Someone who has administrator access over the python travis should be able to trigger a rebuild. From a quick look it would be every RP after this one: python/cpython#5449. Another view on travis that should help is this: https://travis-ci.org/python/cpython/pull_requests

   Of course PRs that change only documentation don't need a rebuild, it should also be easy to see if the full build went through by the time taken.
8. brettcannon commented on Feb 21, 2018

   

   brettcannon

   on Feb 21, 2018

   Member

   More actions

   can this issue be closed?
9. berkerpeksag commented on Feb 21, 2018

   

   berkerpeksag

   on Feb 21, 2018

   Member

   More actions

   I think we close this now. Thank you everyone!
10. berkerpeksag

    closed this as completedon Feb 21, 2018