Repository navigation
Start using CODEOWNERS #160
Description
https://github.com/blog/2392-introducing-code-owners
Since mention-bot seems to be perpetually down, we might as well drop it and switch over to the CODEOWNER file instead. Not sure how we want this to interact with https://devguide.python.org/experts/, though (e.g. script to generate CODEOWNERS from the experts file, link to CODEOWNERS from the experts file?).
Activity
brettcannon commentedon Jul 27, 2017
FYI the free mention-bot instance we were using is down which used to do something similar for us: facebookarchive/mention-bot#230. So it might be time to drop mention-bot and just switch to this opt-in solution.
Mariatta commentedon Jul 27, 2017
I started the CODEOWNERS file python/cpython#2924
Haven't really thought how to add in the experts list from the devguide to CODEOWNERS file 😛
Should we first verify if the list of experts is accurate?
Mariatta commentedon Jul 27, 2017
Also, the experts list contains b.p.o usernames. We need GitHub userid for CODEOWNERS.
brettcannon commentedon Jul 28, 2017
Yep, which is why I haven't just added
CODEOWNERSsince there's no good solution. 😉 I would say we should dropexperts.rstand just useCODEOWNERS, but that won't work since we need that for the nosy list on bugs.python.org. We could query b.p.o for people's GitHub usernames, but that doesn't translate to file globs thatCODEOWNERSneeds.I think we're stuck with comments in both files saying "make sure to update the other one as appropriate" and cross-linking so people know about both files. 😞
brettcannon commentedon Jul 28, 2017
And we should just tell people to add themselves to
CODEOWNERSonce the file is in instead of making bad assumptions about which files they care about.Mariatta commentedon Aug 1, 2017
We now have
CODEOWNERSfile (python/cpython#2924), and.mention-bothas been removed from all branches (python/cpython#2923)! 🌮brettcannon commentedon Aug 1, 2017
Thanks for the PRs, @Mariatta !