Repository navigation
Conversation
webknjaz
reviewed
May 31, 2019
webknjaz
reviewed
May 31, 2019
| - &run-if-tagged | ||
| if: tag IS present | ||
| - &run-if-cherry-picker | ||
| if: tag =~ ^cherry\-picker\-v\d+\.\d+\.\d+$ |
Member
There was a problem hiding this comment.
This can be hugely simplified now
Member
Author
There was a problem hiding this comment.
Can you suggest how? I'm not actually very well-versed in config file like this 😅
Member
There was a problem hiding this comment.
Just use that other anchor without a regex
webknjaz
reviewed
May 31, 2019
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
webknjaz
reviewed
May 31, 2019
Member
|
Now that there's no blurb, script+install could be moved to the root level and most of the anchors aren't needed so the config could be ~two times smaller. |
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Member
|
If you want, I can take care of simplifying this config. |
Member
Author
Yes! I'll appreciate this. Thanks! |
Merged
Member
|
#11 should do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.