Skip to content

A way to force cherry_picker to never open a web browser #4

Closed

Description

@gpshead

Cherry picker calls the webbrowser module from open_pr to open a web browser. I never want this. My terminal windows are most often not capable of opening a useful web browser and as such may resort to opening dumb terminal browsers like links or lynx that I refuse to tough github with. Just print the URL (as it already does) and leave it at that.

Some people may want a web browser. making it an option (I don't care what the default is) is fine by me.

Activity

  1. Mariatta commented on Nov 14, 2018

    @Mariatta
    Member

    GitMate.io thinks possibly related issues are python/core-workflow#55 (cherry_picker.py opens wrong page), python/core-workflow#140 (Move cherry_picker over to flit), python/core-workflow#113 (Questions about cherry-picker from Windows never-venv user), python/core-workflow#50 (Add a setup command to cherry_picker), and python/core-workflow#78 (Add --no-push option to cherry_picker.py).

  2. Mariatta commented on Nov 14, 2018

    @Mariatta
    Member

    Sure. Now that we have config file, it can be added as an option in the config file.

  3. webknjaz commented on Nov 19, 2018

    @webknjaz
    Member

    @gpshead I think if you supply a github token it would skip opening the window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions