Skip to content

Fix UnixNoGilRefleakBuild.testFlags - #417

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:fix_nogil_refleak
Oct 4, 2023
Merged

vstinner merged 1 commit into
python:mainfrom
vstinner:fix_nogil_refleak

Conversation

@vstinner

@vstinner vstinner commented Oct 4, 2023

Copy link
Copy Markdown
Member

It must be a list, no a string.

Correctly, the builder fails with:

./python -E  -m test --slow-ci --timeout=12000 - R   3 : 3   - u - c p u --junit-xml test-results.xml -j2 --fail-rerun
regrtest.py: error: unrecognized arguments: -

It must be a list, no a string.

Correctly, the builder fails with:

    ./python -E  -m test --slow-ci --timeout=12000 - R   3 : 3   - u - c p u --junit-xml test-results.xml -j2 --fail-rerun
    regrtest.py: error: unrecognized arguments: -
@vstinner

vstinner commented Oct 4, 2023

Copy link
Copy Markdown
Member Author

cc @itamaro: I made changes recently, maybe your PR landed "while" I was doing these changes.

@vstinner
vstinner enabled auto-merge (squash) October 4, 2023 12:38
@vstinner
vstinner merged commit fcb15d0 into python:main Oct 4, 2023
@vstinner
vstinner deleted the fix_nogil_refleak branch October 4, 2023 12:40
@vstinner

vstinner commented Oct 4, 2023

Copy link
Copy Markdown
Member Author

Example of builder failure: https://buildbot.python.org/all/#/builders/1226/builds/228

@itamaro

itamaro commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

Thank you for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants