Skip to content

master.utils submodule fails to import #412

Closed

Description

@AlexWaygood
(venv) C:\Users\alexw\coding\buildmaster-config>python -c "import master.utils"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "C:\Users\alexw\coding\buildmaster-config\master\utils.py", line 3, in <module>
    from jinja2 import Markup
ImportError: cannot import name 'Markup' from 'jinja2' (C:\Users\alexw\coding\buildmaster-config\venv\Lib\site-packages\jinja2\__init__.py)

jinja.Markup doesn't exist with Jinja2==3.1.2.

Not sure if this submodule is really needed? (I don't really know anything about this codebase.)

Activity

  1. vstinner commented on Sep 29, 2023

    @vstinner
    Member

    REPLACEMENTS and changecommentlink are no longer used. Do you want to propose a PR to remove this file?

  2. AlexWaygood commented on Sep 29, 2023

    @AlexWaygood
    MemberAuthor

    REPLACEMENTS and changecommentlink are no longer used. Do you want to propose a PR to remove this file?

    Filed #413 to do that. FYI, I found this by running mypy on the codebase -- was curious to see if it would spot anything obvious after #409 (comment) slipped through unnoticed :-)

  3. vstinner commented on Sep 29, 2023

    @vstinner
    Member

    I should run pyflakes to detect such obvious mistake, twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions