Skip to content

Would you support calling blurb test from unpacked sdist? #21

Closed

Description

@hroncok

The short story

It would be nice if I could run blurb test from a directory called blurb-1.2.0. Which is the name when I download and unpack the sdist.

Long version

I package blurb for Fedora and I build it from unpackaged sdist. The following code prevents me from running blurb test :

blurb/src/blurb/blurb.py

Lines 831 to 836 in 07bb15c

while not os.path.isdir("blurb"):
old_dir = os.getcwd()
os.chdir("..")
if old_dir == os.getcwd():
# we reached the root and never found it!
sys.exit("Error: Couldn't find the root of your blurb repo!")

It would be great If I did not have to do this:

mkdir blurb
mv tests blurb
cd blurb
blurb test
cd ..
mv blurb/tests .

Would you accept a change that would make this easier for me?

Thanks for blurb!

Activity

  1. changed the title [-]Would you support calling blurb tests from unpackeg sdist?[/-] [+]Would you support calling blurb test from unpackeg sdist?[/+] on Jul 8, 2024
  2. changed the title [-]Would you support calling blurb test from unpackeg sdist?[/-] [+]Would you support calling blurb test from unpacked sdist?[/+] on Jul 19, 2024
  3. hugovk commented on Jul 19, 2024

    @hugovk
    Member

    This sounds reasonable. Although at EuroPython, did you tell me it wasn't so easy?

    Perhaps check if the dir begins with "blurb"?

  4. hroncok commented on Jul 19, 2024

    @hroncok
    ContributorAuthor

    I assumed it won't be that easy, because it is using paths like this:

    directory = "blurb/tests/pass"

    Yet maybe that does not really matter. I will check.

  5. hroncok commented on Jul 22, 2024

    @hroncok
    ContributorAuthor

    I solved this by removing the blurb/ prefix form the directory attribute: #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions