Teach Bedevere to suggest regenerated configure file #537

Activity

1. arhadthedev

   added

   enhancement

   on Feb 6, 2023
2. arhadthedev commented on Apr 12, 2023

   

   arhadthedev

   on Apr 12, 2023

   MemberAuthor

   More actions

   Triggering Bedevere via events will create something like this:

   

   but worse. The whole approach needs to be redesigned.
3. corona10 commented on Apr 12, 2023

   

   corona10

   on Apr 12, 2023

   Last edited by corona10

   Member

   More actions

   To modify configure.ac, contributors need to use the https://github.com/tiran/cpython_autoconf Docker image. However, Windows users are out of luck; for my contributions I need to use a throwaway GitHub Actions workflow.

   I am not sure for this suggestion.
   If user didn't regenerate configure file, how do we can belive that user verify the change in their local environment?
4. arhadthedev commented on Apr 13, 2023

   

   arhadthedev

   on Apr 13, 2023

   MemberAuthor

   More actions

   Fortunately, Check if generated files are up to date already prints a diff that perfectly solves the underlying issue without adding anything to Bedevere:

             if test -n "$changes"; then
               echo "Generated files not up to date."
               echo "Perhaps you forgot to run make regen-all or build.bat --regen. ;)"
               echo "configure files must be regenerated with a specific version of autoconf."
               echo "$changes"
               echo ""
               git diff --staged || true
               exit 1
             fi

   Thus closing.
5. arhadthedev

   closed this as not plannedon Apr 13, 2023