Update Codecov global YAML

@thomasrockhu-codecov

Suggestion from #432:

Tom from Codecov here. Just saw this PR and wanted to offer my help in case you ran into any issues.

Looking at the global yaml, I'd recommend changing to

comment: false
coverage:
  status:
    changes: false
    patch:
      default:
        informational: true
    project:
      default:
        informational: true

to get non-blocking status checks on PRs

Originally posted by @thomasrockhu-codecov in #432 (comment)

The global YAML can be updated at https://app.codecov.io/account/gh/python/yaml

I've updated the YAML to the above. For reference, here is what it was before:

comment: false
coverage:
  status:
    changes: false
    patch: false
    project: false

@thomasrockhu-codecov

I created #442 and coverage was sent to Codecov: https://codecov.io/gh/python/bedevere/commit/98bca146646c8bd29f3b6cd25c6dc4193e412046/

But no comment was created.

The repo.github/.codecov.yml is:

comment: true

https://app.codecov.io/gh/python/bedevere/commit/98bca146646c8bd29f3b6cd25c6dc4193e412046 shows the combined YAML:

codecov:
  require_ci_to_pass: true
comment: true
coverage:
  precision: 2
  range:
  - 70.0
  - 100.0
  round: down
  status:
    changes: false
    default_rules:
      flag_coverage_not_uploaded_behavior: include
    patch:
      default:
        informational: true
    project:
      default:
        informational: true
github_checks:
  annotations: true

@thomasrockhu-codecov Do you know what we're missing?

@hugovk

@hugovk nothing comes up immediately to me. I'll need a little time to dig in to figure this out if you don't mind.

Thank you!

@hugovk

@hugovk, sorry it took so long to get back, could you try removing comment: true from the yaml? This is a bug on our end with the way we are parsing the yaml.

Thanks, done in PR #444. I deleted the .github/.codecov.yml file because it only contains comment: true.

There's no comment on that PR, does it need merging first?

@hugovk

No, I don't think so @hugovk let me get back to you on this

@hugovk

@hugovk I think the problem with removing it completely, is that the global yaml will still be in effect. I think in order to get over that, there needs to be something in the yaml for comment. Sorry for making you do this again, but I would do

comment:
  layout: "reach, diff, flags, files"

or something similar

Sure, please see PR #446. And it worked, thank you!

@hugovk

Glad that worked @hugovk!

Navigation Menu

Repository navigation

Update Codecov global YAML #441

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Update Codecov global YAML #441

Description

Activity

hugovk commented on Apr 25, 2022

hugovk commented on Apr 25, 2022

thomasrockhu-codecov commented on Apr 26, 2022

hugovk commented on Apr 26, 2022

thomasrockhu-codecov commented on Apr 26, 2022

hugovk commented on Apr 27, 2022

thomasrockhu-codecov commented on Apr 27, 2022

thomasrockhu-codecov commented on Apr 29, 2022

hugovk commented on Apr 29, 2022

thomasrockhu-codecov commented on Apr 29, 2022

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions