Restore support for bpo-* issue numbers in PR titles

@Mariatta

It seems that after #420 bedevere only looks for GH numbers:

Lines 12 to 29 in cd97d6b

    
           ISSUE_RE = re.compile(r"gh-(?P<issue>\d+)") 
        
           SKIP_ISSUE_LABEL = util.skip_label("issue") 
        
           STATUS_CONTEXT = "bedevere/issue-number" 
        
           # Try to keep descriptions at or below 50 characters, else GitHub's CSS will truncate it. 
        
           SKIP_ISSUE_STATUS = util.create_status(STATUS_CONTEXT, util.StatusState.SUCCESS, 
        
                                                  description="Issue report skipped") 
        
           @router.register("pull_request", action="opened") 
        
           @router.register("pull_request", action="synchronize") 
        
           @router.register("pull_request", action="reopened") 
        
           async def set_status(event, gh, *args, session, **kwargs): 
        
               """Set the issue number status on the pull request.""" 
        
               issue_number_found = ISSUE_RE.search(event.data["pull_request"]["title"]) 
        
               if not issue_number_found: 
        
                   issue = await util.issue_for_PR(gh, event.data["pull_request"]) 
        
                   status = (SKIP_ISSUE_STATUS if util.skip("issue", issue) 
        
                                               else create_failure_status_no_issue())

This should be updated to try GH first, and fallback on bpo if a GH number is missing (assuming something is done with the id and the distinction matters, otherwise a single check is enough).

While we are at it, should it also be case-insensitive or do we want to enforce lowercase gh-*?

cc @Mariatta, @brettcannon

You should be able to just tweak the regex and update the tests.

P.S. I announced a while back I was stepping down from heading up infrastructure stuff, so I'm not the best person to be cc'ing to get stuff done. 😉

Restore support for "bpo-XXX: title" headers

Restore support for "bpo-XXX: title" headers (#437)

Navigation Menu

Repository navigation

Restore support for `bpo-*` issue numbers in PR titles #426

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	ISSUE_RE = re.compile(r"gh-(?P<issue>\d+)")
	SKIP_ISSUE_LABEL = util.skip_label("issue")
	STATUS_CONTEXT = "bedevere/issue-number"
	# Try to keep descriptions at or below 50 characters, else GitHub's CSS will truncate it.
	SKIP_ISSUE_STATUS = util.create_status(STATUS_CONTEXT, util.StatusState.SUCCESS,
	description="Issue report skipped")


	@router.register("pull_request", action="opened")
	@router.register("pull_request", action="synchronize")
	@router.register("pull_request", action="reopened")
	async def set_status(event, gh, args, session, *kwargs):
	"""Set the issue number status on the pull request."""
	issue_number_found = ISSUE_RE.search(event.data["pull_request"]["title"])
	if not issue_number_found:
	issue = await util.issue_for_PR(gh, event.data["pull_request"])
	status = (SKIP_ISSUE_STATUS if util.skip("issue", issue)
	else create_failure_status_no_issue())

Restore support for bpo-* issue numbers in PR titles #426

Description

Activity

brettcannon commented on Apr 12, 2022

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

Restore support for `bpo-*` issue numbers in PR titles #426