Skip to content

Update bedevere for the GitHub migration #418

Closed

Description

@ezio-melotti

Currently bedevere does the following things:

  • checks if a bpo link is present in the PR
    • this check is no longer necessary for bpo
    • it might need to be updated to check for a GH or bpo issue
    • eventually the bpo check could be removed
  • adds a link to PRs that points to the corresponding bpo issues
    • the link should be updated to use the bpo-* form to enable redirects
      • is it possible to update existing links?
    • it might need to add links to the GH issues
    • eventually the bpo link addition can be removed
  • adds labels automatically

cc @brettcannon

Activity

  1. Mariatta commented on Mar 24, 2022

    @Mariatta
    Member

    I've just opened the PR for handling the new labels: #419
    I noticed the bpo- check while working on it. I'll try to work on a PR.

  2. Mariatta commented on Mar 24, 2022

    @Mariatta
    Member

    adds a link to PRs that points to the corresponding bpo issues

    I'm planning to just remove this functionality completely, so that bedevere will no longer be appending issue link at the end. Is this ok?

  3. brettcannon commented on Mar 24, 2022

    @brettcannon
    Member

    adds a link to PRs that points to the corresponding bpo issues

    I'm planning to just remove this functionality completely, so that bedevere will no longer be appending issue link at the end. Is this ok?

    I think so.

  4. ezio-melotti commented on Mar 24, 2022

    @ezio-melotti
    MemberAuthor

    The reason to change from the full link to bpo-* (or better just add bpo-* next to it) is that bpo-* can automatically redirect to the right GH issue without having to go through the bpo issue manually. That's also why I was asking if it's possible to update old links -- if not, people will have to deal with a click more and some extra loading time, but it's not the end of the world.

    It might be useful to wait a few days to disable the feature, to leave some time for people to adjust to the new workflow (some might still use the bpo ID if they are not sure what todo). After that the feature can be removed, unless you want to check that the PR is linked to an existing GH issue instead.

  5. Mariatta commented on Mar 25, 2022

    @Mariatta
    Member

    Oh I have started removing the bpo- thing altogether before I saw your comment. (see #420)

    Updating old prs that has bpo- in it can perhaps be done using one-off script.

  6. added a commit that references this issue on Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions