Skip to content

Changing labels when a review gets requested #219

Closed
Closed
Changing labels when a review gets requested#219

Description

@lysnikolaou
lysnikolaou
opened on Apr 24, 2020

While working on python/cpython#19694, I found out that labels don't change, if a PR has been approved and the author requests a review once more.

I think it would be a good idea to change the label back to awaiting core review, when a review gets requested. Thoughts?

Activity

  1. brettcannon commented on Apr 24, 2020

    @brettcannon
    brettcannon
    on Apr 24, 2020
    Member

    Seems reasonable. I know @vstinner has been worried about changes made post-approval when auto-merge is turned on. Maybe it's worth resetting the reviews as well?

  2. Mariatta commented on Apr 24, 2020

    @Mariatta
    Mariatta
    on Apr 24, 2020
    Member

    Related issue: python/core-workflow#325

  3. Mariatta commented on May 19, 2020

    @Mariatta
    Mariatta
    on May 19, 2020
    Member

    This has been addressed in #220. Thanks.

  4. Mariatta
    closed this as completedon May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions