Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BTC SegWit and lowercase/uppercase ETH address validators accept a valid address followed by a final newline because
$can match before it. For example,btc_address("bc1qar0srrr7xfkvy5l643lydnw9re59gtzzwf5mdq" + "\n")currently returnsTrue.Use full matches for the two complete-address patterns. Existing alphabets, legacy BTC and mixed-case ETH checksums, and provider behavior are preserved; SegWit remains the documented approximate regex check. This overlaps the ETH regex line in #448, whose broader provider/checksum rewrite still uses prefix matches and does not resolve this newline acceptance.
Validation: the new 20-case suite has four failures on unchanged master; all 100 crypto tests and all 1,191 tests/doctests pass after the fix. Official tox lint, type, format, sast and py314 checks pass on Python 3.14.8. Other supported interpreter versions were not run locally.
Prepared with OpenAI Codex assistance and independently reviewed before submission.