Skip to content

fix(i18n/fr): reject comma as gender/Corsica suffix in fr_ssn #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nandgator merged 1 commit into from
Oct 10, 2026
Merged

fix(i18n/fr): reject comma as gender/Corsica suffix in fr_ssn #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/validators/i18n/fr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
def _ssn_pattern():
"""SSN Pattern."""
return re.compile(
r"^([1,2])" # gender (1=M, 2=F)
r"^([12])" # gender (1=M, 2=F)
r"\s(\d{2})" # year of birth
r"\s(0[1-9]|1[0-2])" # month of birth
r"\s(\d{2,3}|2[A,B])" # department of birth
r"\s(\d{2,3}|2[AB])" # department of birth
r"\s(\d{2,3})" # town of birth
r"\s(\d{3})" # registration number
r"(?:\s(\d{2}))?$", # control key (may or may not be provided)
Expand Down
1 change: 1 addition & 0 deletions tests/i18n/test_fr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ def test_returns_true_on_valid_ssn(value: str):
(None,),
("",),
("3 84 12 76 451 089 46",), # wrong gender number
(", 84 12 76 451 089",), # comma is not a valid gender (regex char-class bug)
("1 84 12 76 451 089 47",), # wrong control key
("1 84 00 76 451 089",), # invalid month
("1 84 13 76 451 089",), # invalid month
Expand Down
Loading