Repository navigation
Deprecate sslmode in favor of user and implementation configured policies. #75
Description
Activity
I don't recall "verify-full" being around when I wrote it. Also, I don't believe certificate verification had a documented interface (Python's built-in ssl module) when I wrote it as well.
- changed the title
[-]Improper SSL certificate verification[/-][+]Implement SSL certificate verification "verify-full" sslmode[/+]on Jun 17, 2015 Postgres also has
verify-cafor sslmode which should be included in support.- changed the title
[-]Implement SSL certificate verification "verify-full" sslmode[/-][+]Implement "verify-full" and "verify-ca" sslmode[/+]on Jun 16, 2021 Looks like recent
sslversions perform at least one level of certificate verification. With libpq, the entire chain is checked according to https://www.postgresql.org/docs/current/libpq-ssl.html#LIBQ-SSL-CERTIFICATESI think the future of
sslmodein py-postgresql is deprecation.Mimicking libpq's connect behavior was one of the more painful features to implement and playing catch-up with features that are primarily intended for
psqlsessions doesn't really fit well when Python'ssslhas its own means for configuring policies.- changed the title
[-]Implement "verify-full" and "verify-ca" sslmode[/-][+]Deprecate `sslmode` in favor of user and implementation configured policies.[/+]on Feb 10, 2023 Plan for this will be to introduce the
secureparameter in v1.4, and emit deprecation warnings in a subsequent bug fix.
I'm having issues getting SSL certificate verification to fail - even when using self signed certificates, different hostnames, or passing a random root ca.
Therefore I think it is safe to assume SSL certificate verification is broken.
ssl.wrap_socket does not verify the hostname, ssl.match_hostname is not used in the code.
And - the sslmode keywords differ from postgresql sslmode keywords, having at least "verify-full" would be good.