Skip to content

Handling of isort-related errors and other autofix codes #29

Description

@jhossbach

With #25 being merged soon, the question remains whether formatting should be enabled by default and error codes should be given to be auto-fixed when running formatting.
I don't really mind on or the other, so I'm open to suggestions.

If e.g. isort-codes should be used for formatting per default, we should also disable pylsp-isort.

Activity

  1. changed the title [-]Handling of isort-related errors[/-] [+]Handling of isort-related errors and other autofix codes[/+] on Apr 4, 2023
  2. Shane-XB-Qian commented on Apr 17, 2023

    @Shane-XB-Qian
    Contributor

    i am curious to ask if this can offer 'additionalTextEdits' which offer auto-fix for auto-import when writing a method but did not import it yet.

  3. jhossbach commented on Apr 20, 2023

    @jhossbach
    MemberAuthor

    That depends on whether ruff supports this kind of action. I couldn't find any immediate support for that, but as far as I know rope (and thus pylsp-rope) supports this.

  4. Shane-XB-Qian commented on Apr 21, 2023

    @Shane-XB-Qian
    Contributor
  5. jhossbach commented on Apr 21, 2023

    @jhossbach
    MemberAuthor

    You could create a feature request issue on ruff's github but i think the idea of ruff is to stay on providing linting features rather than code reformat actions. Nevertheless it might be worth the try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions