Repository navigation
Clarify that the Headers class is a Sequence - #125
Merged
Merged
Conversation
bluetech
approved these changes
Dec 28, 2020
bluetech
left a comment
bluetech
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Optionally, Sequence has an __iter__ mixin so you could remove the manual implementation if you want.
This is both in the docs (via the changelog) and by inheriting from the Sequence ABC. As the Sequence ABC has a __iter__ method another is not required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is both in the docs (via the changelog) and by inheriting from
the Sequence ABC.