Repository navigation
Content length handling - #109
Merged
Merged
Conversation
This ensures that duplicate content length headers with a value of b"0" are correctly considered.
Member
Author
|
@tomchristie & @sethmlarson @StephenBrown2 Does this look good to you? I think it is probably worth getting into the next release. |
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
=======================================
Coverage 99.16% 99.17%
=======================================
Files 21 21
Lines 959 966 +7
Branches 175 178 +3
=======================================
+ Hits 951 958 +7
Misses 7 7
Partials 1 1
Continue to review full report at Codecov.
|
sethmlarson
requested changes
Oct 4, 2020
sethmlarson
left a comment
sethmlarson
left a comment
Member
There was a problem hiding this comment.
Some performance optimizations, looks good otherwise.
If duplicated exactly when merged into a comma seperated list (the unmerged case is handled already). This is allowed as per RFC 7230 Section 3.3.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92