Repository navigation
naturaldelta() raises OverflowError on float('inf') instead of returning it unchanged #333
Description
Summary
naturaldelta() documents that a non-finite float value is "returned unchanged." nan is handled (its int() raises ValueError, which is caught), but float('inf')/float('-inf') raise an uncaught OverflowError from int(value), because the except (ValueError, TypeError) clause omits OverflowError. The behavior is asymmetric and contradicts the docstring.
Reproduction
import humanize
print(humanize.naturaldelta(float("nan"))) # 'nan' (handled)
print(humanize.naturaldelta(float("inf"))) # OverflowError: cannot convert float infinity to integerExpected
naturaldelta(float("inf")) returns the value unchanged (symmetric with nan), per the docstring.
Actual
Uncaught OverflowError.
Fix sketch
Include OverflowError in the caught exceptions around the int(value) guard (time.py ~L149).
Environment
humanize 4.15.1.dev (main @ c2c410c), Python 3.12.
Activity
fix(naturaldelta): catch OverflowError for float('inf') (python-human…
Mukller commentedon Jul 29, 2026
Root cause confirmed: the guard around
int(value)only catchesValueErrorandTypeError, butint(float('inf'))raisesOverflowError.float('nan')is silently handled becauseint(nan)raisesValueError. Butint(float('inf'))raisesOverflowError, which propagates uncaught.Fix: add
OverflowErrorto the except clause:I have a PR ready.
test: regression for python-humanize#333 non-finite float OverflowErr…