Repository navigation
Add python 3.13 wheel #146
Description
python 3.13 is planned to be released on the 2024-10-01. Some days ago the first beta release was published. Early adopters cannot consume it for now when they don't want to build grimp locally. It would be great if you could offer a 3.13 prebuild wheel
Metadata
Metadata
Assignees
Labels
No labels
Activity
seddonym commentedon Jun 5, 2024
Thanks for requesting this. I've now updated the release steps so next time I do a release, it should 🤞🏻 build a wheel for Python 3.13. I'm not planning to do a release just for that though, it'll have to come along in the next release, hopefully in the next few weeks if not sooner.
I've also created a PR to formally support Python 3.13 but it's not possible to run the tests yet due to a downstream issue.
kasium commentedon Jun 5, 2024
Sounds great, thanks a lot!
seddonym commentedon Jun 13, 2024
I'm afraid I had to back out the release of the 3.13 wheel as Py03 (a Rust crate which we use to provide Python binding to Rust) doesn't yet support 3.13.
Example failure.
kasium commentedon Jun 14, 2024
Seems like the next release of py03 should add support? PyO3/pyo3#4038
seddonym commentedon Jun 14, 2024
Thanks for the link. I've subscribed to that issue now so I should be able to add this once they release 0.22.
kasium commentedon Jul 9, 2024
@seddonym py03 with 3.13 support was released
seddonym commentedon Jul 12, 2024
Hmm, I just released Grimp 3.4.1 with support for Python 3.13. But for some reason the wheels are only being built for Windows. E.g. have a look in this job for linux x86_64 - it installs Python 3.13 the Build wheels step only builds wheels for the other Python versions.
Troubleshooting this kind of thing isn't my strong point, to be perfectly honest. If anyone has any ideas I'm all ears.
kasium commentedon Jul 17, 2024
I had a short look and what I can see is, that in the linux build job, the following line is logged
In difference for windows
According to PyO3/maturin#1960 (comment) and the following comments, there are some version combinations to consider; but I guess we need to wait until 3.13 is officially released
kasium commentedon Oct 7, 2024
@seddonym 3.13 was released today. Can you please check if you can provide a wheel now?
seddonym commentedon Oct 8, 2024
Thanks for the nudge, yes I'll look into this ASAP.
seddonym commentedon Oct 8, 2024
Github automatically closed this, reopening until I can see it working!
seddonym commentedon Oct 8, 2024
Well, I just released 3.5 and I'm afraid it still isn't including the Python 3.13 wheels, except for Windows 😞 . I'm guessing it's because the setup-python Github action doesn't yet include Python 3.13?
If anyone has any advice I'm all ears!
Here's a link to the workflow: https://github.com/seddonym/grimp/actions/runs/11236773243
kasium commentedon Oct 9, 2024
setup-python just allowed 3.13 :-)
seddonym commentedon Oct 9, 2024
I tried setting up this PR just for the purposes of publishing the additional wheels, but no joy. Here's the release workflow.
The setup-python step does seem to install Python 3.13.0.
But the build wheels step doesn't for some reason find it.
seddonym commentedon Oct 9, 2024
I think the issue might be with Maturin's discovery of Python interpreters.
The good news is, I tried explicitly setting the interpreter and the wheels have now built and published! https://pypi.org/project/grimp/3.5/#files
But this was still a very manual process. I'm going to close this ticket for now and will keep an eye on whether it works for the next release.
kasium commentedon Oct 9, 2024
Thanks a lot