Skip to content

Jarvis - #400

Merged
pawangeek merged 5 commits into
python-geeks:mainfrom
anshul2807:main
Aug 24, 2021
Merged

Jarvis#400
pawangeek merged 5 commits into
python-geeks:mainfrom
anshul2807:main

Conversation

@anshul2807

@anshul2807 anshul2807 commented Aug 23, 2021 •

Copy link
Copy Markdown
Contributor

Pull Request Template

##Issue no. - #398

Self Check(Tick After Making pull Request)

  • This issue was assigned to me.
  • One Change in one Pull Request
  • My file is in proper folder (Name of folder should be in lowercase with no space in between)
  • I am following clean code and Documentation and my code is well linted with flake8.
  • I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.

@anshul2807 anshul2807 changed the title Jarvis(assistant) issue #398 Jarvis #398 Aug 23, 2021

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! 🎉 @anshul2807 for making your first PR. We will review the changes soon and merge finally.😊 Do give a star ⭐ meanwhile if you like this project.

@anshul2807 anshul2807 changed the title Jarvis #398 Jarvis Aug 23, 2021
@pawangeek

Copy link
Copy Markdown
Contributor

Fix lint

@anshul2807

Copy link
Copy Markdown
Contributor Author

fixed with flake8.

@pawangeek pawangeek linked an issue Aug 23, 2021 that may be closed by this pull request
1 task done
@pawangeek

Copy link
Copy Markdown
Contributor

Hey, @anshul2807 Just last one thing, change the folder name to 'jarvis_assistant'

@anshul2807

Copy link
Copy Markdown
Contributor Author

jarvis_assistant

Done.

@pawangeek
pawangeek merged commit f1063d6 into python-geeks:main Aug 24, 2021
@pawangeek

Copy link
Copy Markdown
Contributor

@all-contributors add @anshul2807 for code

@allcontributors

Copy link
Copy Markdown
Contributor

@pawangeek

I've put up a pull request to add @anshul2807! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jarvis(assistant)

2 participants