Skip to content

Aliveness check endpoint #117

Open
Open

Description

@ChrisLovering

Implement a /ping endpoint (or similar) so that we can check when the system is ready to serve requests.

This should only return a 2XX code once all caches are up to date.

Activity

  1. vcokltfre commented on Jun 20, 2021

    @vcokltfre
    Contributor

    Can I implement this one :P

  2. ChrisLovering commented on Jun 20, 2021

    @ChrisLovering
    MemberAuthor

    As part of this, we should also move GET /size back into the general router, so it requires auth

  3. ChrisLovering commented on Jun 20, 2021

    @ChrisLovering
    MemberAuthor

    Can I implement this one :P

    Yes :) But I suggest waiting until #106 is merged :P

  4. Akarys42 commented on Jun 20, 2021

    @Akarys42
    Contributor

    Bikeshed: /healthcheck is a better name for the route :P

  5. ChrisLovering commented on Jun 24, 2021

    @ChrisLovering
    MemberAuthor

    Maybe two endpoints? An aliveness check which returns as soon as it's serving, and then a readiness check, which is when the caches are ready.

    This will line up with the checks we can configure in k8s

  6. ChrisLovering commented on Jun 24, 2021

    @ChrisLovering
    MemberAuthor

    On second thought, and some discussion in #dev-pixels having one health check endpoint should be enough.

    As long as it returns when the caches are ready, we can use that for a liveness and readiness check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions